NE-1936: Bump k8s.io dependencies to v0.32.1 #1184

alebedev87 · 2025-01-20T21:50:14Z

Upgraded k8s.io/api, k8s.io/apiextensions-apiserver, and k8s.io/client-go to v0.32.1.
Updated sigs.k8s.io/controller-runtime to v0.20.1 (compatible with k8s v0.32).
Go version was implicitly bumped to 1.23.0 as part of the dependency updates.

Commands used for the upgrade:

go get k8s.io/[email protected]
go get k8s.io/[email protected]
go mod edit -replace k8s.io/client-go=k8s.io/[email protected]
go get sigs.k8s.io/[email protected]
go mod tidy
go mod vendor

openshift-ci-robot · 2025-01-20T21:50:18Z

@alebedev87: This pull request references NE-1936 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Upgraded k8s.io/api, k8s.io/apiextensions-apiserver, and k8s.io/client-go to v0.32.1.

Updated sigs.k8s.io/controller-runtime to v0.20.0 (compatible with k8s v0.32).

Go version was implicitly bumped to 1.23.0 as part of the dependency updates.

Commands used for the upgrade:
   go get k8s.io/[email protected]
   go get k8s.io/[email protected]
   go mod edit -replace k8s.io/client-go=k8s.io/[email protected]
   go get sigs.k8s.io/[email protected]
   go mod tidy
   go mod vendor

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2025-01-20T21:53:40Z

@alebedev87: This pull request references NE-1936 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Upgraded k8s.io/api, k8s.io/apiextensions-apiserver, and k8s.io/client-go to v0.32.1.

Updated sigs.k8s.io/controller-runtime to v0.20.0 (compatible with k8s v0.32).

Go version was implicitly bumped to 1.23.0 as part of the dependency updates.

Commands used for the upgrade:
go get k8s.io/[email protected]
go get k8s.io/[email protected]
go mod edit -replace k8s.io/client-go=k8s.io/[email protected]
go get sigs.k8s.io/[email protected]
go mod tidy
go mod vendor

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

alebedev87 · 2025-01-21T06:53:22Z

/retest

alebedev87 · 2025-01-21T14:51:06Z

/retest

Miciah · 2025-01-22T16:02:39Z

/assign

alebedev87 · 2025-01-23T14:04:08Z

openshift/origin#29466 is supposed to fix e2e-aws-ocn-serial.

gcs278 · 2025-01-23T18:22:37Z

go.mod

-	k8s.io/utils v0.0.0-20240711033017-18e509b52bc8
-	sigs.k8s.io/controller-runtime v0.19.0
+	k8s.io/utils v0.0.0-20241104100929-3ea5e8cea738
+	sigs.k8s.io/controller-runtime v0.20.0


0.20.1 is out (that was quick). I see two fixes (kubernetes-sigs/controller-runtime#3079 and kubernetes-sigs/controller-runtime#3086) that might be of interest. Up to you if you want to bump again.

https://github.com/kubernetes-sigs/controller-runtime/releases/tag/v0.20.1

Right, I saw they dropped a new one. Let me add it.

- Upgraded k8s.io/api, k8s.io/apiextensions-apiserver, and k8s.io/client-go to v0.32.1. - Updated sigs.k8s.io/controller-runtime to v0.20.1 (compatible with k8s v0.32). - Go version was implicitly bumped to 1.23.0 as part of the dependency updates. Commands used for the upgrade: go get k8s.io/[email protected] go get k8s.io/[email protected] go mod edit -replace k8s.io/client-go=k8s.io/[email protected] go get sigs.k8s.io/[email protected] go mod tidy go mod vendor

openshift-ci-robot · 2025-01-24T17:10:54Z

@alebedev87: This pull request references NE-1936 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Upgraded k8s.io/api, k8s.io/apiextensions-apiserver, and k8s.io/client-go to v0.32.1.

Updated sigs.k8s.io/controller-runtime to v0.20.1 (compatible with k8s v0.32).

Go version was implicitly bumped to 1.23.0 as part of the dependency updates.

Commands used for the upgrade:
go get k8s.io/[email protected]
go get k8s.io/[email protected]
go mod edit -replace k8s.io/client-go=k8s.io/[email protected]
go get sigs.k8s.io/[email protected]
go mod tidy
go mod vendor

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

alebedev87 · 2025-01-28T07:57:04Z

/retest

candita · 2025-02-26T22:36:43Z

/cc @shaneutt

knobunc · 2025-03-03T16:20:33Z

/approve

openshift-ci · 2025-03-03T16:20:57Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: knobunc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [knobunc]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

knobunc · 2025-03-03T16:20:57Z

/lgtm

openshift-ci-robot · 2025-03-03T19:07:01Z

/retest-required

Remaining retests: 0 against base HEAD 26f8b0f and 2 for PR HEAD 6ed63fe in total

Miciah · 2025-03-03T19:41:36Z

e2e-gcp-operator failed because TestConnectTimeout and TestUnmanagedDNSToManagedDNSIngressController failed:

=== NAME  TestAll/parallel/TestConnectTimeout
    operator_test.go:3321: got unexpected error while sending request: Get "http://34.136.99.34": dial tcp 34.136.99.34:80: i/o timeout
    operator_test.go:3349: failed to observe expected condition: context deadline exceeded
=== NAME  TestAll/parallel/TestConnectTimeout
    operator_test.go:3234: deleted ingresscontroller test-connect-timeout

=== NAME  TestAll/parallel/TestUnmanagedDNSToManagedDNSIngressController
    util_test.go:109: retrying client call due to: Get "http://34.29.34.185": context deadline exceeded (Client.Timeout exceeded while awaiting headers)
    unmanaged_dns_test.go:74: failed to verify connectivity with workload with reqURL http://34.29.34.185 using external client: timed out waiting for the condition

Looks like infrastructure issues.

openshift-ci-robot · 2025-03-04T01:23:05Z

/retest-required

Remaining retests: 0 against base HEAD 26f8b0f and 2 for PR HEAD 6ed63fe in total

openshift-ci · 2025-03-04T03:31:35Z

@alebedev87: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-bot · 2025-03-04T07:24:44Z

[ART PR BUILD NOTIFIER]

Distgit: ose-cluster-ingress-operator
This PR has been included in build ose-cluster-ingress-operator-container-v4.19.0-202503040641.p0.g69cadab.assembly.stream.el9.
All builds following this will include this PR.

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 20, 2025

openshift-ci bot requested review from gcs278 and miheer January 20, 2025 21:51

openshift-ci bot assigned Miciah Jan 22, 2025

gcs278 reviewed Jan 23, 2025

View reviewed changes

alebedev87 force-pushed the ne-1936-bump-k8s-1-32 branch from bdcd59b to ff1f469 Compare January 24, 2025 16:55

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 24, 2025

alebedev87 force-pushed the ne-1936-bump-k8s-1-32 branch from ff1f469 to 6ed63fe Compare January 24, 2025 16:58

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 24, 2025

openshift-ci bot requested a review from shaneutt February 26, 2025 22:36

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 3, 2025

openshift-ci bot assigned knobunc Mar 3, 2025

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 3, 2025

openshift-merge-bot bot merged commit 69cadab into openshift:master Mar 4, 2025
19 checks passed

alebedev87 mentioned this pull request Mar 4, 2025

NE-1953: Add Validating Admission Policy for Gateway API CRDs #1192

Merged

NE-1936: Bump k8s.io dependencies to v0.32.1 #1184

NE-1936: Bump k8s.io dependencies to v0.32.1 #1184

Uh oh!

Conversation

alebedev87 commented Jan 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Jan 20, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Jan 20, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alebedev87 commented Jan 21, 2025

Uh oh!

alebedev87 commented Jan 21, 2025

Uh oh!

Miciah commented Jan 22, 2025

Uh oh!

alebedev87 commented Jan 23, 2025

Uh oh!

gcs278 Jan 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alebedev87 Jan 24, 2025

Choose a reason for hiding this comment

Uh oh!

openshift-ci-robot commented Jan 24, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alebedev87 commented Jan 28, 2025

Uh oh!

candita commented Feb 26, 2025

Uh oh!

knobunc commented Mar 3, 2025

Uh oh!

openshift-ci bot commented Mar 3, 2025

Uh oh!

knobunc commented Mar 3, 2025

Uh oh!

openshift-ci-robot commented Mar 3, 2025

Uh oh!

Miciah commented Mar 3, 2025

Uh oh!

openshift-ci-robot commented Mar 4, 2025

Uh oh!

openshift-ci bot commented Mar 4, 2025

Uh oh!

Uh oh!

openshift-bot commented Mar 4, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

alebedev87 commented Jan 20, 2025 •

edited

Loading

openshift-ci-robot commented Jan 20, 2025 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Jan 20, 2025 •

edited by openshift-ci bot

Loading

gcs278 Jan 23, 2025 •

edited

Loading

openshift-ci-robot commented Jan 24, 2025 •

edited by openshift-ci bot

Loading