NE-2115: Implement httpsLogFormat and tcpLogFormat for Ingress Operator #1274
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@rohara: This pull request references NE-2115 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/assign @rikatz |
| RouterTCPLogFormatEnvName = "ROUTER_TCP_LOG_FORMAT" | ||
| RouterHTTPLogFormatEnvName = "ROUTER_HTTP_LOG_FORMAT" | ||
| RouterHTTPSLogFormatEnvName = "ROUTER_HTTPS_LOG_FORMAT" |
There was a problem hiding this comment.
Need to run gofmt on this.
| } | ||
|
|
||
| if len(accessLogging.TcpLogFormat) > 0 { | ||
| env = append(env, corev1.EnvVar{Name: RouterTCPLogFormatEnvName, Value: fmt.Sprintf("%q", accessLogging.TcpLogFormat)}) |
There was a problem hiding this comment.
Where do we validate the format for these?
|
@rohara: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
6 participants
Add support for httpsLogFormat and tcpLogFormat. These allow users to define a custom log format for both HTTPS and TCP traffic, which configured appropriately in OpenShift Router.