Skip to content

Commit 05014ca

Browse files
Merge pull request #1891 from vrutkovs/revert-1869-revert-1853-rotation-when-expired-fix
Revert "Revert "OCPBUGS-56551: certregenerationcontroller: start configInformers again""
2 parents a9e5d47 + 4163755 commit 05014ca

File tree

1 file changed

+5
-4
lines changed
  • pkg/cmd/certregenerationcontroller

1 file changed

+5
-4
lines changed

pkg/cmd/certregenerationcontroller/cmd.go

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -109,10 +109,6 @@ func (o *Options) Run(ctx context.Context, clock clock.Clock) error {
109109
return err
110110
}
111111

112-
// We can't start informers until after the resources have been requested. Now is the time.
113-
kubeAPIServerInformersForNamespaces.Start(ctx.Done())
114-
dynamicInformers.Start(ctx.Done())
115-
116112
desiredVersion := status.VersionForOperatorFromEnv()
117113
missingVersion := "0.0.1-snapshot"
118114
featureGateAccessor := featuregates.NewFeatureGateAccess(
@@ -154,6 +150,11 @@ func (o *Options) Run(ctx context.Context, clock clock.Clock) error {
154150
return err
155151
}
156152

153+
// We can't start informers until after the resources have been requested. Now is the time.
154+
kubeAPIServerInformersForNamespaces.Start(ctx.Done())
155+
dynamicInformers.Start(ctx.Done())
156+
configInformers.Start(ctx.Done())
157+
157158
// FIXME: These are missing a wait group to track goroutines and handle graceful termination
158159
// (@deads2k wants time to think it through)
159160

0 commit comments

Comments
 (0)