OCPBUGS-13635: make webhook connection failure a warning in log

mfojtik · openshift-cherrypick-robot · commit 3ecbb3806cdf · 2023-08-01T11:05:01.000Z
diff --git a/pkg/operator/webhooksupportabilitycontroller/degraded_webhook.go b/pkg/operator/webhooksupportabilitycontroller/degraded_webhook.go
@@ -131,8 +131,8 @@ func (c *webhookSupportabilityController) assertConnect(ctx context.Context, web
 		conn, err = dialer.DialContext(ctx, "tcp", net.JoinHostPort(host, port))
 		if err != nil {
 			if i != 2 {
-				// log err since only last one is reported
-				runtime.HandleError(fmt.Errorf("%s: %v", webhookName, err))
+				// log warning since only last one is reported
+				klog.Warningf("failed to connect to webhook %q via service %q: %v", webhookName, net.JoinHostPort(host, port), err)
 			}
 			continue
 		}

Original file line number	Diff line number	Diff line change
`@@ -131,8 +131,8 @@ func (c *webhookSupportabilityController) assertConnect(ctx context.Context, web`
`131`	`131`	`conn, err = dialer.DialContext(ctx, "tcp", net.JoinHostPort(host, port))`
`132`	`132`	`if err != nil {`
`133`	`133`	`if i != 2 {`
`134`		`- // log err since only last one is reported`
`135`		`- runtime.HandleError(fmt.Errorf("%s: %v", webhookName, err))`
	`134`	`+ // log warning since only last one is reported`
	`135`	`+ klog.Warningf("failed to connect to webhook %q via service %q: %v", webhookName, net.JoinHostPort(host, port), err)`
`136`	`136`	`}`
`137`	`137`	`continue`
`138`	`138`	`}`