Skip to content

Commit e69ff94

Browse files
Merge pull request #1869 from neisw/revert-1853-rotation-when-expired-fix
Revert "OCPBUGS-56551: certregenerationcontroller: start configInformers again"
2 parents 04595ca + 74eb7e3 commit e69ff94

File tree

1 file changed

+4
-5
lines changed
  • pkg/cmd/certregenerationcontroller

1 file changed

+4
-5
lines changed

pkg/cmd/certregenerationcontroller/cmd.go

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -109,6 +109,10 @@ func (o *Options) Run(ctx context.Context, clock clock.Clock) error {
109109
return err
110110
}
111111

112+
// We can't start informers until after the resources have been requested. Now is the time.
113+
kubeAPIServerInformersForNamespaces.Start(ctx.Done())
114+
dynamicInformers.Start(ctx.Done())
115+
112116
desiredVersion := status.VersionForOperatorFromEnv()
113117
missingVersion := "0.0.1-snapshot"
114118
featureGateAccessor := featuregates.NewFeatureGateAccess(
@@ -150,11 +154,6 @@ func (o *Options) Run(ctx context.Context, clock clock.Clock) error {
150154
return err
151155
}
152156

153-
// We can't start informers until after the resources have been requested. Now is the time.
154-
kubeAPIServerInformersForNamespaces.Start(ctx.Done())
155-
dynamicInformers.Start(ctx.Done())
156-
configInformers.Start(ctx.Done())
157-
158157
// FIXME: These are missing a wait group to track goroutines and handle graceful termination
159158
// (@deads2k wants time to think it through)
160159

0 commit comments

Comments
 (0)