Skip to content

Commit 1a8653f

Browse files
committed
add review comments
Signed-off-by: Mario Fernandez <[email protected]>
1 parent 3080181 commit 1a8653f

File tree

2 files changed

+7
-0
lines changed

2 files changed

+7
-0
lines changed

pkg/manifests/manifests.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1472,6 +1472,7 @@ func (f *Factory) PrometheusK8s(grpcTLS *v1.Secret, telemetrySecret *v1.Secret)
14721472
for i, container := range p.Spec.Containers {
14731473
switch container.Name {
14741474
case "prometheus":
1475+
// Inject the proxy env vars into the Prometheus container for configuring external Alertmanagers
14751476
f.injectProxyVariables(&p.Spec.Containers[i])
14761477
case "kube-rbac-proxy", "kube-rbac-proxy-web", "kube-rbac-proxy-thanos":
14771478
p.Spec.Containers[i].Image = f.config.Images.KubeRbacProxy

pkg/manifests/manifests_test.go

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1988,6 +1988,12 @@ func TestPrometheusK8sAdditionalAlertManagerConfigsSecret(t *testing.T) {
19881988
expected string
19891989
mountedSecrets []string
19901990
}{
1991+
{
1992+
name: "empty config",
1993+
config: "",
1994+
expected: "[]\n",
1995+
mountedSecrets: []string{},
1996+
},
19911997
{
19921998
name: "basic config",
19931999
config: `prometheusK8s:

0 commit comments

Comments
 (0)