Skip to content

OCPBUGS-61088: create networkpolicy settings for in-cluster monitoring #2656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 84 commits into
base: main
Choose a base branch
from
Open

OCPBUGS-61088: create networkpolicy settings for in-cluster monitoring #2656

wants to merge 84 commits into from

Conversation

@juzhao
Copy link
Contributor

@juzhao juzhao commented Sep 1, 2025

see https://issues.redhat.com/browse/OCPBUGS-61088, use this bug to set networkpolicy for in-cluster monitoring
this PR replaced #2645, 2645 does not include networkpolicy settings for alertmanager/prometheus/thanos-querier, since there is default deny network settings for all monitoring pods, if we don't include them, CI jobs would be failed for them

@juzhao juzhao mentioned this pull request Sep 1, 2025
Closed
@juzhao
Copy link
Contributor Author

juzhao commented Sep 1, 2025

/retitle [WIP] OCPBUGS-61088: create networkpolicy settings for in-cluster monitoring

@openshift-ci openshift-ci bot changed the title add networkpolicy settings for in-cluster monitoring [WIP] OCPBUGS-61088: create networkpolicy settings for in-cluster monitoring Sep 1, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 1, 2025
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 1, 2025
@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Sep 1, 2025
@openshift-ci-robot
Copy link
Contributor

@juzhao: This pull request references Jira Issue OCPBUGS-61088, which is invalid:

  • expected the bug to target the "4.20.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

see https://issues.redhat.com/browse/OCPBUGS-61088, use this bug to set networkpolicy for in-cluster monitoring
this PR replaced #2645, 2645 does not include networkpolicy settings for alertmanager/prometheus/thanos-querier, since there is default deny network settings for all monitoring pods, if we don't include them, CI jobs would be failed for them

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@juzhao
Copy link
Contributor Author

juzhao commented Sep 1, 2025

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Sep 1, 2025
@openshift-ci-robot
Copy link
Contributor

@juzhao: This pull request references Jira Issue OCPBUGS-61088, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.20.0) matches configured target version for branch (4.20.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @juzhao

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 1, 2025

@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: juzhao.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@juzhao: This pull request references Jira Issue OCPBUGS-61088, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.20.0) matches configured target version for branch (4.20.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @juzhao

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

simonpasquier
simonpasquier reviewed Sep 1, 2025
View reviewed changes
@juzhao
Copy link
Contributor Author

juzhao commented Sep 2, 2025

/retest

@juzhao
Copy link
Contributor Author

juzhao commented Sep 3, 2025

/test verify
/test rules
/test generate

@juzhao
Copy link
Contributor Author

juzhao commented Sep 5, 2025

/retest

@juzhao
Copy link
Contributor Author

juzhao commented Sep 25, 2025

/test e2e-aws-ovn-techpreview

@juzhao
Copy link
Contributor Author

juzhao commented Sep 25, 2025

/test e2e-agnostic-operator

1 similar comment
@juzhao
Copy link
Contributor Author

juzhao commented Sep 26, 2025

/test e2e-agnostic-operator

@juzhao
Copy link
Contributor Author

juzhao commented Sep 26, 2025

/retest-required

machine424
machine424 reviewed Sep 26, 2025
View reviewed changes
machine424
machine424 reviewed Sep 26, 2025
View reviewed changes
machine424
machine424 reviewed Sep 26, 2025
View reviewed changes
@openshift-ci-robot openshift-ci-robot removed the verified Signifies that the PR passed pre-merge verification criteria label Sep 28, 2025
@juzhao
Copy link
Contributor Author

juzhao commented Oct 11, 2025

/retest

machine424
machine424 reviewed Oct 14, 2025
View reviewed changes
@juzhao
Copy link
Contributor Author

juzhao commented Oct 20, 2025

/retest

@juzhao
Copy link
Contributor Author

juzhao commented Oct 20, 2025

/retest-required

@juzhao
Copy link
Contributor Author

juzhao commented Oct 20, 2025

/retest

@juzhao
Copy link
Contributor Author

juzhao commented Oct 20, 2025

/retest-required

@juzhao
Copy link
Contributor Author

juzhao commented Oct 20, 2025

/retest

1 similar comment
@juzhao
Copy link
Contributor Author

juzhao commented Oct 21, 2025

/retest

@juzhao
Copy link
Contributor Author

juzhao commented Oct 22, 2025

/retest-required

1 similar comment
@juzhao
Copy link
Contributor Author

juzhao commented Oct 22, 2025

/retest-required

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 23, 2025

@juzhao: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/versions da7a75f link false /test versions
ci/prow/okd-scos-e2e-aws-ovn da7a75f link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@juzhao
Copy link
Contributor Author

juzhao commented Oct 24, 2025 •
edited
Loading

reason for remove node-exporter networkpolicy to open 9100 port: even not open 9100 port for node-exporter, the node-expoert targets are UP and can scrape node-exporter metrics from prometheus, seems the port is open in node, but did not find where it's opened

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jan--f jan--f jan--f left review comments

@simonpasquier simonpasquier simonpasquier left review comments

@rexagod rexagod Awaiting requested review from rexagod

+2 more reviewers

@danielmellado danielmellado danielmellado left review comments

@machine424 machine424 machine424 requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jan--f jan--f

@simonpasquier simonpasquier

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@juzhao @openshift-ci-robot @jan--f @machine424 @danielmellado @simonpasquier @rexagod @slashpai