Skip to content

Commit 6b0d39f

Browse files
committed
Makefile: remove fail-fast from test runs
u/s CI stops the run after 2 failures of the same test, which prevents a full run of the tests. The fail-fast option is better be removed in test runs that do not involve node reboots, that way the CI would reflect a full run of the suite which would help us save reruns to see the next failing test. In other words, removing it will reflect all of the failing tests in one run. remove this flag initially for suites of PP that are known to not have reboots. Signed-off-by: Shereen Haj <shajmakh@redhat.com>
1 parent 7c2dd69 commit 6b0d39f

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

Makefile

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@ test-e2e: $(BINDATA)
9999
test-e2e-local: $(BINDATA) performance-profile-creator-tests gather-sysinfo-tests
100100
$(GO_BUILD_RECIPE)
101101
for d in performanceprofile/functests-render-command/1_render_command; do \
102-
$(GO) test -v -timeout 40m ./test/e2e/$$d -ginkgo.v -ginkgo.no-color -ginkgo.fail-fast || exit; \
102+
$(GO) test -v -timeout 40m ./test/e2e/$$d -ginkgo.v -ginkgo.no-color || exit; \
103103
done
104104

105105
# This target ensures /manifests directory is up-to-date. It takes advantage of yaml patching functionality of
@@ -211,7 +211,7 @@ pao-functests: cluster-label-worker-cnf pao-functests-only
211211
pao-functests-only: $(BINDATA)
212212
@echo "Cluster Version"
213213
hack/show-cluster-version.sh
214-
hack/run-test.sh -t "test/e2e/performanceprofile/functests/0_config test/e2e/performanceprofile/functests/1_performance test/e2e/performanceprofile/functests/6_mustgather_testing test/e2e/performanceprofile/functests/10_performance_ppc" -p "-v -r --fail-fast --flake-attempts=2 --junit-report=report.xml" -m "Running Functional Tests"
214+
hack/run-test.sh -t "test/e2e/performanceprofile/functests/0_config test/e2e/performanceprofile/functests/1_performance test/e2e/performanceprofile/functests/6_mustgather_testing test/e2e/performanceprofile/functests/10_performance_ppc" -p "-v -r --flake-attempts=2 --junit-report=report.xml" -m "Running Functional Tests"
215215

216216
.PHONY: pao-functests-updating-profile
217217
pao-functests-updating-profile: cluster-label-worker-cnf pao-functests-update-only
@@ -235,19 +235,19 @@ pao-functests-performance-workloadhints: cluster-label-worker-cnf pao-functests-
235235
pao-functests-performance-workloadhints-only: $(BINDATA)
236236
@echo "Cluster Version"
237237
hack/show-cluster-version.sh
238-
hack/run-test.sh -t "test/e2e/performanceprofile/functests/0_config test/e2e/performanceprofile/functests/8_performance_workloadhints" -p "-v -r --fail-fast --flake-attempts=2 --timeout=5h --junit-report=report.xml" -m "Running Functional WorkloadHints Tests"
238+
hack/run-test.sh -t "test/e2e/performanceprofile/functests/0_config test/e2e/performanceprofile/functests/8_performance_workloadhints" -p "-v -r --flake-attempts=2 --timeout=5h --junit-report=report.xml" -m "Running Functional WorkloadHints Tests"
239239

240240
.PHONY: pao-functests-latency-testing
241241
pao-functests-latency-testing: dist-latency-tests $(BINDATA)
242242
@echo "Cluster Version"
243243
hack/show-cluster-version.sh
244-
hack/run-test.sh -t "./test/e2e/performanceprofile/functests/0_config ./test/e2e/performanceprofile/functests/5_latency_testing" -p "-v -r --fail-fast --flake-attempts=2 --timeout=5h --junit-report=report.xml" -m "Running Functionalconfiguration latency Tests"
244+
hack/run-test.sh -t "./test/e2e/performanceprofile/functests/0_config ./test/e2e/performanceprofile/functests/5_latency_testing" -p "-v -r --flake-attempts=2 --timeout=5h --junit-report=report.xml" -m "Running Functionalconfiguration latency Tests"
245245

246246
.PHONY: pao-functests-mixedcpus
247247
pao-functests-mixedcpus: $(BINDATA)
248248
@echo "Cluster Version"
249249
hack/show-cluster-version.sh
250-
hack/run-test.sh -t "./test/e2e/performanceprofile/functests/0_config ./test/e2e/performanceprofile/functests/11_mixedcpus" -p "-v -r --fail-fast --flake-attempts=2 --junit-report=report.xml" -m "Running MixedCPUs Tests"
250+
hack/run-test.sh -t "./test/e2e/performanceprofile/functests/0_config ./test/e2e/performanceprofile/functests/11_mixedcpus" -p "-v -r --flake-attempts=2 --junit-report=report.xml" -m "Running MixedCPUs Tests"
251251

252252
.PHONY: pao-functests-hypershift
253253
pao-functests-hypershift: $(BINDATA)
@@ -275,7 +275,7 @@ arm-kernelpagesize: $(BINDATA)
275275
.PHONY: performance-profile-creator-tests
276276
performance-profile-creator-tests: build-performance-profile-creator
277277
@echo "Running Performance Profile Creator Tests"
278-
hack/run-test.sh -t "test/e2e/performanceprofile/functests-performance-profile-creator" -p "--v -r --fail-fast --flake-attempts=2" -m "Running Functional Tests" -r "--junit-report=/tmp/artifacts"
278+
hack/run-test.sh -t "test/e2e/performanceprofile/functests-performance-profile-creator" -p "--v -r --flake-attempts=2" -m "Running Functional Tests" -r "--junit-report=/tmp/artifacts"
279279

280280
# Gather sysinfo binary for use in must-gather
281281
.PHONY: build-gather-sysinfo

0 commit comments

Comments
 (0)