PPC: pkg: public consts to private

The consts are not used anywhere else so make them private.

Signed-off-by: Shereen Haj <shajmakh@redhat.com>

Author: shajmakh

pkg/performanceprofile/profilecreator/ghwhandler.go

@@ -33,17 +33,17 @@ import (
 // NewGHWHandler is a handler to use ghw options corresponding to a node
 func NewGHWHandler(mustGatherDirPath string, node *v1.Node) (*GHWHandler, error) {
 	nodeName := node.GetName()
-	nodePathSuffix := path.Join(Nodes)
-	nodepath, err := getMustGatherFullPathsWithFilter(mustGatherDirPath, nodePathSuffix, ClusterScopedResources)
+	nodePathSuffix := path.Join(nodes)
+	nodepath, err := getMustGatherFullPathsWithFilter(mustGatherDirPath, nodePathSuffix, clusterScopedResources)
 	if err != nil {
 		return nil, fmt.Errorf("can't obtain the node path %s: %v", nodeName, err)
 	}
-	_, err = os.Stat(path.Join(nodepath, nodeName, SysInfoFileName))
+	_, err = os.Stat(path.Join(nodepath, nodeName, sysInfoFileName))
 	if err != nil {
 		return nil, fmt.Errorf("can't obtain the path: %s for node %s: %v", nodeName, nodepath, err)
 	}
 	options := ghw.WithSnapshot(ghw.SnapshotOptions{
-		Path: path.Join(nodepath, nodeName, SysInfoFileName),
+		Path: path.Join(nodepath, nodeName, sysInfoFileName),
 	})
 	ghwHandler := &GHWHandler{snapShotOptions: options, Node: node}
 	return ghwHandler, nil

pkg/performanceprofile/profilecreator/mustgather.go

@@ -29,22 +29,22 @@ import (
 )
 
 const (
-	// ClusterScopedResources defines the subpath, relative to the top-level must-gather directory.
+	// clusterScopedResources defines the subpath, relative to the top-level must-gather directory.
 	// A top-level must-gather directory is of the following format:
 	// must-gather-dir/quay-io-openshift-kni-performance-addon-operator-must-gather-sha256-<Image SHA>
 	// Here we find the cluster-scoped definitions saved by must-gather
-	ClusterScopedResources = "cluster-scoped-resources"
-	// CoreNodes defines the subpath, relative to ClusterScopedResources, on which we find node-specific data
-	CoreNodes = "core/nodes"
-	// MCPools defines the subpath, relative to ClusterScopedResources, on which we find the machine config pool definitions
-	MCPools = "machineconfiguration.openshift.io/machineconfigpools"
-	// YAMLSuffix is the extension of the yaml files saved by must-gather
-	YAMLSuffix = ".yaml"
-	// Nodes defines the subpath, relative to top-level must-gather directory, on which we find node-specific data
-	Nodes = "nodes"
-	// SysInfoFileName defines the name of the file where ghw snapshot is stored
-	SysInfoFileName = "sysinfo.tgz"
-	// defines the sub path relative to ClusterScopedResources, on which OCP infrastructure object is
+	clusterScopedResources = "cluster-scoped-resources"
+	// coreNodes defines the subpath, relative to ClusterScopedResources, on which we find node-specific data
+	coreNodes = "core/nodes"
+	// mcpools defines the subpath, relative to ClusterScopedResources, on which we find the machine config pool definitions
+	mcpools = "machineconfiguration.openshift.io/machineconfigpools"
+	// yamlSuffix is the extension of the yaml files saved by must-gather
+	yamlSuffix = ".yaml"
+	// nodes defines the subpath, relative to top-level must-gather directory, on which we find node-specific data
+	nodes = "nodes"
+	// sysInfoFileName defines the name of the file where ghw snapshot is stored
+	sysInfoFileName = "sysinfo.tgz"
+	// configOCPInfra defines the sub path relative to ClusterScopedResources, on which OCP infrastructure object is
 	configOCPInfra = "config.openshift.io/infrastructures"
 )
 
@@ -80,7 +80,7 @@ func getMustGatherFullPaths(mustGatherPath string, suffix string) (string, error
 
 func getNode(mustGatherDirPath, nodeName string) (*v1.Node, error) {
 	var node v1.Node
-	nodePathSuffix := path.Join(ClusterScopedResources, CoreNodes, nodeName)
+	nodePathSuffix := path.Join(clusterScopedResources, coreNodes, nodeName)
 	path, err := getMustGatherFullPaths(mustGatherDirPath, nodePathSuffix)
 	if err != nil {
 		return nil, fmt.Errorf("failed to get MachineConfigPool for %s: %v", nodeName, err)
@@ -103,7 +103,7 @@ func getNode(mustGatherDirPath, nodeName string) (*v1.Node, error) {
 func GetNodeList(mustGatherDirPath string) ([]*v1.Node, error) {
 	machines := make([]*v1.Node, 0)
 
-	nodePathSuffix := path.Join(ClusterScopedResources, CoreNodes)
+	nodePathSuffix := path.Join(clusterScopedResources, coreNodes)
 	nodePath, err := getMustGatherFullPaths(mustGatherDirPath, nodePathSuffix)
 	if err != nil {
 		return nil, fmt.Errorf("failed to get Nodes from must gather directory: %v", err)
@@ -131,7 +131,7 @@ func GetNodeList(mustGatherDirPath string) ([]*v1.Node, error) {
 func GetMCPList(mustGatherDirPath string) ([]*machineconfigv1.MachineConfigPool, error) {
 	pools := make([]*machineconfigv1.MachineConfigPool, 0)
 
-	mcpPathSuffix := path.Join(ClusterScopedResources, MCPools)
+	mcpPathSuffix := path.Join(clusterScopedResources, mcpools)
 	mcpPath, err := getMustGatherFullPaths(mustGatherDirPath, mcpPathSuffix)
 	if err != nil {
 		return nil, fmt.Errorf("failed to get MCPs: %v", err)
@@ -161,7 +161,7 @@ func GetMCPList(mustGatherDirPath string) ([]*machineconfigv1.MachineConfigPool,
 func GetMCP(mustGatherDirPath, mcpName string) (*machineconfigv1.MachineConfigPool, error) {
 	var mcp machineconfigv1.MachineConfigPool
 
-	mcpPathSuffix := path.Join(ClusterScopedResources, MCPools, mcpName+YAMLSuffix)
+	mcpPathSuffix := path.Join(clusterScopedResources, mcpools, mcpName+yamlSuffix)
 	mcpPath, err := getMustGatherFullPaths(mustGatherDirPath, mcpPathSuffix)
 	if err != nil {
 		return nil, fmt.Errorf("failed to obtain MachineConfigPool %s: %v", mcpName, err)

pkg/performanceprofile/profilecreator/profilecreator.go

@@ -570,7 +570,7 @@ func IsLogicalProcessorUsed(extCPUInfo *extendedCPUInfo, logicalProcessor int) b
 
 // IsExternalControlPlaneCluster return whether the control plane is running on externally outside the cluster
 func IsExternalControlPlaneCluster(mustGatherDirPath string) (bool, error) {
-	infraPath := path.Join(ClusterScopedResources, configOCPInfra, "cluster.yaml")
+	infraPath := path.Join(clusterScopedResources, configOCPInfra, "cluster.yaml")
 	fullInfraPath, err := getMustGatherFullPaths(mustGatherDirPath, infraPath)
 	if fullInfraPath == "" || err != nil {
 		return false, fmt.Errorf("failed to get Infrastructure object from must gather directory path: %s; %w", mustGatherDirPath, err)