Skip to content

Conversation

tmshort
Copy link
Contributor

@tmshort tmshort commented Oct 22, 2025

Add an apiserver TLS config observer. This examines TLS config and
copies the values into the .spec.observedConfig field of the
olms.operator.openshift.io/cluster resource. This is then used to
apply configuration to the operator-controller and catalogd.

The configuration is applied to those deployments via:

  • --tls-custom-ciphers=X,Y,Z
  • --tls-custom-version=N
  • --tls-profile=custom

In addition:

  • Update library-go to include the TLS config observer
  • Move the deployment update hooks (proxy, TLS) into their own files
  • Add unit tests
  • Changed Apply()s to Patch()s when modifying olms to avoid overwrites

Signed-off-by: Todd Short [email protected]
Co-Authored-By: Claude [email protected]

@openshift-ci-robot openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Oct 22, 2025
@openshift-ci-robot
Copy link

@tmshort: This pull request references Jira Issue OCPBUGS-62173, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.21.0) matches configured target version for branch (4.21.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Add an apiserver TLS config observer. This examines TLS config and copies the values into the .spec.observedConfig field of the olms.operator.openshift.io/cluster resource. This is then used to apply configuration to the operator-controller and catalogd.

The configuration is applied to those deployments via:

  • --tls-custom-ciphers=X,Y,Z
  • --tls-custom-version=N
  • --tls-profile=custom

In addition:

  • Update library-go to include the TLS config observer
  • Move the deployment update hooks (proxy, TLS) into their own files
  • Add unit tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 22, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 22, 2025
@openshift-ci-robot
Copy link

@tmshort: This pull request references Jira Issue OCPBUGS-62173, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.21.0) matches configured target version for branch (4.21.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

In response to this:

Add an apiserver TLS config observer. This examines TLS config and
copies the values into the .spec.observedConfig field of the
olms.operator.openshift.io/cluster resource. This is then used to
apply configuration to the operator-controller and catalogd.

The configuration is applied to those deployments via:

  • --tls-custom-ciphers=X,Y,Z
  • --tls-custom-version=N
  • --tls-profile=custom

In addition:

  • Update library-go to include the TLS config observer
  • Move the deployment update hooks (proxy, TLS) into their own files
  • Add unit tests
  • Changed Apply()s to Patch()s when modifying olms to avoid overwrites

Signed-off-by: Todd Short [email protected]
Co-Authored-By: Claude [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@tmshort
Copy link
Contributor Author

tmshort commented Oct 22, 2025

/test openshift-e2e-aws
/test openshift-e2e-aws-techpreview

@tmshort tmshort force-pushed the tlsprofiles3 branch 2 times, most recently from 95cfa2b to 642bcb0 Compare October 22, 2025 20:50
@camilamacedo86
Copy link

/retest-required

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 23, 2025
Add an apiserver TLS config observer. This examines TLS config and
copies the values into the .spec.observedConfig field of the
olms.operator.openshift.io/cluster resource. This is then used to
apply configuration to the operator-controller and catalogd.

The configuration is applied to those deployments via:
* --tls-custom-ciphers=X,Y,Z
* --tls-custom-version=N
* --tls-profile=custom

In addition:
* Move the deployment update hooks (proxy, TLS) into their own files
* Add unit tests
* Changed Apply()s to Patch()s when modifying olms to avoid overwrites
* Update fieldManagers to avoid overwrites

Signed-off-by: Todd Short <[email protected]>
Co-Authored-By: Claude <[email protected]>
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 23, 2025
@tmshort
Copy link
Contributor Author

tmshort commented Oct 23, 2025

openshift-e2e-aws-devpreview is failing with this:

: [sig-network-edge][Conformance][Area:Networking][Feature:Router] The HAProxy router should be able to connect to a service that is idled because a GET on the route will unidle it [Suite:openshift/conformance/parallel/minimal] 

Which seems unrelated. After approvals, I will re-run it, but I may override it.

@tmshort
Copy link
Contributor Author

tmshort commented Oct 23, 2025

/test openshift-e2e-aws-devpreview

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 23, 2025

@tmshort: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn de8017a link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants