config: Conditionally initialize configuration controller

The information regarding enabled feature gates is now available
sooner in the code. Utilize this information to conditionally initialize
the configuration controller. The subsequent code can then easily check
for existence of the configuration using a nil.

Author: DavidHurta

pkg/cvo/cvo.go

@@ -290,7 +290,9 @@ func New(
 	// make sure this is initialized after all the listers are initialized
 	optr.upgradeableChecks = optr.defaultUpgradeableChecks()
 
-	optr.configuration = configuration.NewClusterVersionOperatorConfiguration(operatorClient, operatorInformerFactory)
+	if shouldReconcileCVOConfiguration(cvoGates, optr.hypershift) {
+		optr.configuration = configuration.NewClusterVersionOperatorConfiguration(operatorClient, operatorInformerFactory)
+	}
 
 	return optr, nil
 }
@@ -483,7 +485,7 @@ func (optr *Operator) Run(runContext context.Context, shutdownContext context.Co
 		resultChannel <- asyncResult{name: "available updates"}
 	}()
 
-	if optr.shouldReconcileCVOConfiguration() {
+	if optr.configuration != nil {
 		resultChannelCount++
 		go func() {
 			defer utilruntime.HandleCrash()
@@ -1070,7 +1072,7 @@ func (optr *Operator) HTTPClient() (*http.Client, error) {
 // shouldReconcileCVOConfiguration returns whether the CVO should reconcile its configuration using the API server.
 //
 // enabledFeatureGates must be initialized before the function is called.
-func (optr *Operator) shouldReconcileCVOConfiguration() bool {
+func shouldReconcileCVOConfiguration(enabledFeatureGates featuregates.CvoGateChecker, isHypershift bool) bool {
 	// The relevant CRD and CR are not applied in HyperShift, which configures the CVO via a configuration file
-	return optr.enabledFeatureGates.CVOConfiguration() && !optr.hypershift
+	return enabledFeatureGates.CVOConfiguration() && !isHypershift
 }