Skip to content

Commit 22f3553

Browse files
committed
cmd/start: Include the version in the outgoing log line
Lala wanted the version included in the outgoing log line [1]. I'm not sure why you'd be wondering which version of the CVO code was running for that particular line, and not for other lines in the log, but including the version there is easy enough. While we're thinking about logging the CVO version, also remove the useless %s formatting from the opening log line, because we don't need to manipulate version.String at all. [1]: #424 (comment)
1 parent 9c42a92 commit 22f3553

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

cmd/start.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,12 +18,12 @@ func init() {
1818
Long: "",
1919
Run: func(cmd *cobra.Command, args []string) {
2020
// To help debugging, immediately log version
21-
klog.Infof("%s", version.String)
21+
klog.Info(version.String)
2222

2323
if err := opts.Run(context.Background()); err != nil {
2424
klog.Fatalf("error: %v", err)
2525
}
26-
klog.Info("Graceful shutdown complete.")
26+
klog.Infof("Graceful shutdown complete for %s.", version.String)
2727
},
2828
}
2929

0 commit comments

Comments
 (0)