Skip to content

Commit 2c87f33

Browse files
committed
lib/resourcemerge/core: Reconcile ConfigMap binaryData too
Since 4.20, some Cluster-API ConfigMap manifests have wanted to set this: $ oc adm release extract --to manifests quay.io/openshift-release-dev/ocp-release:4.20.10-x86_64 $ grep -r binaryData manifests manifests/0000_30_cluster-api_04_cm.infrastructure-aws.yaml:binaryData: so we need to compare the in-cluster ConfigMap with this property as well, when deciding if the resource needs updating.
1 parent 62ee569 commit 2c87f33

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

lib/resourcemerge/core.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ import (
1515
func EnsureConfigMap(modified *bool, existing *corev1.ConfigMap, required corev1.ConfigMap) {
1616
EnsureObjectMeta(modified, &existing.ObjectMeta, required.ObjectMeta)
1717

18+
mergeMap(modified, &existing.BinaryData, required.BinaryData)
1819
mergeMap(modified, &existing.Data, required.Data)
1920
}
2021

0 commit comments

Comments
 (0)