Merge pull request #503 from LalatenduMohanty/bz_1918085

openshift-merge-robot · web-flow · commit 41af279cfd4c · 2021-01-20T09:57:08.000-05:00
Bug 1918085: Fixing the log message in WaitForJobCompletion()
diff --git a/lib/resourcebuilder/batch.go b/lib/resourcebuilder/batch.go
@@ -18,7 +18,7 @@ func WaitForJobCompletion(ctx context.Context, client batchclientv1.JobsGetter,
 			klog.Error(err)
 			return false, nil
 		} else if !done {
-			klog.V(4).Infof("Job %s in namespace %s is not ready, continuing to wait.", job.ObjectMeta.Namespace, job.ObjectMeta.Name)
+			klog.V(4).Infof("Job %s in namespace %s is not ready, continuing to wait.", job.ObjectMeta.Name, job.ObjectMeta.Namespace)
 			return false, nil
 		}
 		return true, nil

Original file line number	Diff line number	Diff line change
`@@ -18,7 +18,7 @@ func WaitForJobCompletion(ctx context.Context, client batchclientv1.JobsGetter,`
`18`	`18`	`klog.Error(err)`
`19`	`19`	`return false, nil`
`20`	`20`	`} else if !done {`
`21`		`- klog.V(4).Infof("Job %s in namespace %s is not ready, continuing to wait.", job.ObjectMeta.Namespace, job.ObjectMeta.Name)`
	`21`	`+ klog.V(4).Infof("Job %s in namespace %s is not ready, continuing to wait.", job.ObjectMeta.Name, job.ObjectMeta.Namespace)`
`22`	`22`	`return false, nil`
`23`	`23`	`}`
`24`	`24`	`return true, nil`