Merge pull request #484 from wking/taskless-node-panic

openshift-merge-robot · web-flow · commit 6c55d1e46b91 · 2021-02-02T00:24:15.000-05:00
Bug 1903382: pkg/payload/task_graph: Require firstIncompleteNode to have tasks
diff --git a/pkg/payload/task_graph.go b/pkg/payload/task_graph.go
@@ -536,7 +536,7 @@ func RunGraph(ctx context.Context, graph *TaskGraph, maxParallelism int, fn func
 	incompleteCount := 0
 	for i, result := range results {
 		if result == nil {
-			if firstIncompleteNode == nil {
+			if firstIncompleteNode == nil && len(graph.Nodes[i].Tasks) > 0 {
 				firstIncompleteNode = graph.Nodes[i]
 			}
 			incompleteCount++

Original file line number	Diff line number	Diff line change
`@@ -536,7 +536,7 @@ func RunGraph(ctx context.Context, graph *TaskGraph, maxParallelism int, fn func`
`536`	`536`	`incompleteCount := 0`
`537`	`537`	`for i, result := range results {`
`538`	`538`	`if result == nil {`
`539`		`- if firstIncompleteNode == nil {`
	`539`	`+ if firstIncompleteNode == nil && len(graph.Nodes[i].Tasks) > 0 {`
`540`	`540`	`firstIncompleteNode = graph.Nodes[i]`
`541`	`541`	`}`
`542`	`542`	`incompleteCount++`