Skip to content

Commit 7676d46

Browse files
committed
pkg/cvo/cvo_scenarios_test.go: Modify TestCVO_ParallelError
Due to the introduced filtering of UpdateError errors before setting the Failing condition, it is needed to update the TestCVO_ParallelError test, as its errors are getting rightfully filtered due to their UpdateEffect being None. This commit is utilizing this chance to update the UpdateEffect of one of the errors to test the filtering here as well.
1 parent ac72abe commit 7676d46

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

pkg/cvo/cvo_scenarios_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3568,7 +3568,7 @@ func TestCVO_ParallelError(t *testing.T) {
35683568
},
35693569
"0000_20_a_file.yaml": nil,
35703570
"0000_20_b_file.yaml": &payload.UpdateError{
3571-
UpdateEffect: payload.UpdateEffectNone,
3571+
UpdateEffect: payload.UpdateEffectFail,
35723572
Message: "Failed to reconcile 20-b-file resource",
35733573
},
35743574
}}
@@ -3753,7 +3753,7 @@ func TestCVO_ParallelError(t *testing.T) {
37533753
{Type: DesiredReleaseAccepted, Status: configv1.ConditionTrue, Reason: "PayloadLoaded",
37543754
Message: "Payload loaded version=\"1.0.0-abc\" image=\"image/image:1\" architecture=\"" + architecture + "\""},
37553755
{Type: configv1.OperatorAvailable, Status: configv1.ConditionFalse},
3756-
{Type: ClusterStatusFailing, Status: configv1.ConditionTrue, Reason: "MultipleErrors", Message: "Multiple errors are preventing progress:\n* Failed to reconcile 10-a-file resource\n* Failed to reconcile 20-b-file resource"},
3756+
{Type: ClusterStatusFailing, Status: configv1.ConditionTrue, Message: "Failed to reconcile 20-b-file resource"},
37573757
{Type: configv1.OperatorProgressing, Status: configv1.ConditionTrue, Reason: "MultipleErrors", Message: "Unable to apply 1.0.0-abc: an unknown error has occurred: MultipleErrors"},
37583758
{Type: configv1.RetrievedUpdates, Status: configv1.ConditionFalse},
37593759
},

0 commit comments

Comments
 (0)