Merge pull request #185 from wking/more-specific-unknown-error-reporting

openshift-merge-robot · web-flow · commit 914467c03b5b · 2020-04-16T22:49:37.000-07:00
Bug 1825003: pkg/payload/task: Include name/reason in "unknown error" message
diff --git a/pkg/payload/task.go b/pkg/payload/task.go
@@ -222,5 +222,9 @@ func SummaryForReason(reason, name string) string {
 	if strings.HasPrefix(reason, "UpdatePayload") {
 		return "the update could not be applied"
 	}
-	return "an unknown error has occurred"
+
+	if len(name) > 0 {
+		return fmt.Sprintf("%s has an unknown error: %s", name, reason)
+	}
+	return fmt.Sprintf("an unknown error has occurred: %s", reason)
 }

Original file line number	Diff line number	Diff line change
`@@ -222,5 +222,9 @@ func SummaryForReason(reason, name string) string {`
`222`	`222`	`if strings.HasPrefix(reason, "UpdatePayload") {`
`223`	`223`	`return "the update could not be applied"`
`224`	`224`	`}`
`225`		`- return "an unknown error has occurred"`
	`225`	`+`
	`226`	`+ if len(name) > 0 {`
	`227`	`+ return fmt.Sprintf("%s has an unknown error: %s", name, reason)`
	`228`	`+ }`
	`229`	`+ return fmt.Sprintf("an unknown error has occurred: %s", reason)`
`226`	`230`	`}`