remove unnecessary function

Author: RaphaelBut

pkg/investigations/chgm/chgm.go

@@ -82,7 +82,12 @@ func Investigate(r *investigation.Resources) error {
 		logging.Infof("Network verifier reported failure: %s", failureReason)
 
 		if strings.Contains(failureReason, "nosnch.in") {
-			err := r.OcmClient.PostLimitedSupportReason(createEgressLS(), r.Cluster.ID())
+			egressLS := ocm.LimitedSupportReason{
+				Summary: "Cluster is in Limited Support due to unsupported cloud provider configuration",
+				Details: "Your cluster requires you to take action. SRE has observed that there have been changes made to the network configuration which impacts normal working of the cluster, including lack of network egress to internet-based resources which are required for the cluster operation and support. Please revert changes, and refer to documentation regarding firewall requirements for PrivateLink clusters: https://access.redhat.com/documentation/en-us/red_hat_openshift_service_on_aws/4/html/prepare_your_environment/rosa-sts-aws-prereqs#osd-aws-privatelink-firewall-prerequisites_rosa-sts-aws-prereqs#",
+			}
+
+			err := r.OcmClient.PostLimitedSupportReason(&egressLS, r.Cluster.ID())
 			if err != nil {
 				return err
 			}

pkg/investigations/chgm/util.go

@@ -19,14 +19,3 @@ func createEgressSL(blockedUrls string) *ocm.ServiceLog {
 
 	return &egressSL
 }
-
-func createEgressLS() *ocm.LimitedSupportReason {
-	details := "Your cluster requires you to take action. SRE has observed that there have been changes made to the network configuration which impacts normal working of the cluster, including lack of network egress to internet-based resources which are required for the cluster operation and support. Please revert changes, and refer to documentation regarding firewall requirements for PrivateLink clusters: https://access.redhat.com/documentation/en-us/red_hat_openshift_service_on_aws/4/html/prepare_your_environment/rosa-sts-aws-prereqs#osd-aws-privatelink-firewall-prerequisites_rosa-sts-aws-prereqs#"
-
-	egressLS := ocm.LimitedSupportReason{
-		Summary: "Cluster is in Limited Support due to unsupported cloud provider configuration",
-		Details: details,
-	}
-
-	return &egressLS
-}

pkg/investigations/chgm/util_test.go

@@ -29,16 +29,3 @@ func TestCreateEgressSL(t *testing.T) {
 	result := createEgressSL(blockedUrls)
 	assert.Equal(t, *expected, *result)
 }
-
-// TestCreateEgressLS tests the createEgressLS function
-func TestCreateEgressLS(t *testing.T) {
-	expectedDetails := "Your cluster requires you to take action. SRE has observed that there have been changes made to the network configuration which impacts normal working of the cluster, including lack of network egress to internet-based resources which are required for the cluster operation and support. Please revert changes, and refer to documentation regarding firewall requirements for PrivateLink clusters: https://access.redhat.com/documentation/en-us/red_hat_openshift_service_on_aws/4/html/prepare_your_environment/rosa-sts-aws-prereqs#osd-aws-privatelink-firewall-prerequisites_rosa-sts-aws-prereqs#"
-
-	expected := &ocm.LimitedSupportReason{
-		Summary: "Cluster is in Limited Support due to unsupported cloud provider configuration",
-		Details: expectedDetails,
-	}
-
-	result := createEgressLS()
-	assert.Equal(t, *expected, *result)
-}