Skip to content

Commit 5ddff32

Browse files
bergmannfbergmannf
committed
Check the return values in the tests.
1 parent 8153dcc commit 5ddff32

File tree

1 file changed

+112
-28
lines changed

1 file changed

+112
-28
lines changed

‎pkg/investigations/chgm/chgm_test.go

Lines changed: 112 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -107,9 +107,12 @@ var _ = Describe("chgm", func() {
107107
r.OcmClient.(*ocmmock.MockClient).EXPECT().PostServiceLog(gomock.Eq(cluster.ID()), gomock.Eq(&chgmSL)).Return(nil)
108108
r.PdClient.(*pdmock.MockClient).EXPECT().SilenceIncidentWithNote(gomock.Any())
109109

110-
_, gotErr := Investigate(r)
110+
result, gotErr := Investigate(r)
111111

112112
Expect(gotErr).NotTo(HaveOccurred())
113+
Expect(result.ServiceLogPrepared.Performed).To(BeFalse())
114+
Expect(result.ServiceLogSent.Performed).To(BeTrue())
115+
Expect(result.LimitedSupportSet.Performed).To(BeFalse())
113116
})
114117
})
115118
When("Triggered finds instances stopped by the customer with CloudTrail eventVersion 1.99", func() {
@@ -126,19 +129,25 @@ var _ = Describe("chgm", func() {
126129
r.OcmClient.(*ocmmock.MockClient).EXPECT().PostServiceLog(gomock.Eq(cluster.ID()), gomock.Eq(&chgmSL)).Return(nil)
127130
r.PdClient.(*pdmock.MockClient).EXPECT().SilenceIncidentWithNote(gomock.Any())
128131

129-
_, gotErr := Investigate(r)
132+
result, gotErr := Investigate(r)
130133

131134
Expect(gotErr).NotTo(HaveOccurred())
135+
Expect(result.ServiceLogPrepared.Performed).To(BeFalse())
136+
Expect(result.ServiceLogSent.Performed).To(BeTrue())
137+
Expect(result.LimitedSupportSet.Performed).To(BeFalse())
132138
})
133139
})
134140
When("Triggered errors", func() {
135141
It("should update the incident notes and escalate to primary", func() {
136142
r.AwsClient.(*awsmock.MockClient).EXPECT().ListNonRunningInstances(gomock.Any()).Return(nil, fakeErr)
137143
r.PdClient.(*pdmock.MockClient).EXPECT().EscalateIncidentWithNote(gomock.Any()).Return(nil)
138144

139-
_, gotErr := Investigate(r)
145+
result, gotErr := Investigate(r)
140146

141147
Expect(gotErr).NotTo(HaveOccurred())
148+
Expect(result.ServiceLogPrepared.Performed).To(BeFalse())
149+
Expect(result.ServiceLogSent.Performed).To(BeFalse())
150+
Expect(result.LimitedSupportSet.Performed).To(BeFalse())
142151
})
143152
})
144153
When("there were no stopped instances", func() {
@@ -151,9 +160,12 @@ var _ = Describe("chgm", func() {
151160
r.AwsClient.(*awsmock.MockClient).EXPECT().GetSubnetID(gomock.Eq(infraID)).Return([]string{"string1", "string2"}, nil)
152161
r.PdClient.(*pdmock.MockClient).EXPECT().EscalateIncidentWithNote(gomock.Any()).Return(nil)
153162
r.OcmClient.(*ocmmock.MockClient).EXPECT().GetServiceLog(gomock.Eq(cluster), gomock.Eq("log_type='cluster-state-updates'")).Return(&servicelogsv1.ClusterLogsUUIDListResponse{}, nil)
154-
_, gotErr := Investigate(r)
163+
result, gotErr := Investigate(r)
155164
// Assert
156165
Expect(gotErr).ToNot(HaveOccurred())
166+
Expect(result.ServiceLogPrepared.Performed).To(BeFalse())
167+
Expect(result.ServiceLogSent.Performed).To(BeFalse())
168+
Expect(result.LimitedSupportSet.Performed).To(BeFalse())
157169
})
158170
})
159171
When("there was an error getting StopInstancesEvents", func() {
@@ -165,8 +177,11 @@ var _ = Describe("chgm", func() {
165177

166178
r.PdClient.(*pdmock.MockClient).EXPECT().EscalateIncidentWithNote(gomock.Any()).Return(nil)
167179

168-
_, gotErr := Investigate(r)
180+
result, gotErr := Investigate(r)
169181
Expect(gotErr).ToNot(HaveOccurred())
182+
Expect(result.ServiceLogPrepared.Performed).To(BeFalse())
183+
Expect(result.ServiceLogSent.Performed).To(BeFalse())
184+
Expect(result.LimitedSupportSet.Performed).To(BeFalse())
170185
})
171186
})
172187
When("there were no StopInstancesEvents", func() {
@@ -179,8 +194,11 @@ var _ = Describe("chgm", func() {
179194
r.PdClient.(*pdmock.MockClient).EXPECT().EscalateIncidentWithNote(gomock.Any()).Return(nil)
180195

181196
// Act
182-
_, gotErr := Investigate(r)
197+
result, gotErr := Investigate(r)
183198
Expect(gotErr).ToNot(HaveOccurred())
199+
Expect(result.ServiceLogPrepared.Performed).To(BeFalse())
200+
Expect(result.ServiceLogSent.Performed).To(BeFalse())
201+
Expect(result.LimitedSupportSet.Performed).To(BeFalse())
184202
})
185203
})
186204
When("the returned CloudTrailEventRaw base data is correct, but the sessionissue's username is not an authorized user", func() {
@@ -193,9 +211,12 @@ var _ = Describe("chgm", func() {
193211
r.OcmClient.(*ocmmock.MockClient).EXPECT().PostServiceLog(gomock.Eq(cluster.ID()), gomock.Eq(&chgmSL)).Return(nil)
194212
r.PdClient.(*pdmock.MockClient).EXPECT().SilenceIncidentWithNote(gomock.Any()).Return(nil)
195213
// Act
196-
_, gotErr := Investigate(r)
214+
result, gotErr := Investigate(r)
197215
// Assert
198216
Expect(gotErr).NotTo(HaveOccurred())
217+
Expect(result.ServiceLogPrepared.Performed).To(BeFalse())
218+
Expect(result.ServiceLogSent.Performed).To(BeTrue())
219+
Expect(result.LimitedSupportSet.Performed).To(BeFalse())
199220
})
200221
})
201222
When("issuer user is authorized (openshift-machine-api-aws)", func() {
@@ -212,8 +233,11 @@ var _ = Describe("chgm", func() {
212233
r.PdClient.(*pdmock.MockClient).EXPECT().EscalateIncidentWithNote(gomock.Any()).Return(nil)
213234
r.OcmClient.(*ocmmock.MockClient).EXPECT().GetServiceLog(gomock.Eq(cluster), gomock.Eq("log_type='cluster-state-updates'")).Return(&servicelogsv1.ClusterLogsUUIDListResponse{}, nil)
214235

215-
_, gotErr := Investigate(r)
236+
result, gotErr := Investigate(r)
216237
Expect(gotErr).NotTo(HaveOccurred())
238+
Expect(result.ServiceLogPrepared.Performed).To(BeFalse())
239+
Expect(result.ServiceLogSent.Performed).To(BeFalse())
240+
Expect(result.LimitedSupportSet.Performed).To(BeFalse())
217241
})
218242
})
219243
When("username role is OrganizationAccountAccessRole on a non CCS cluster", func() {
@@ -229,8 +253,11 @@ var _ = Describe("chgm", func() {
229253
r.PdClient.(*pdmock.MockClient).EXPECT().EscalateIncidentWithNote(gomock.Any()).Return(nil)
230254
r.OcmClient.(*ocmmock.MockClient).EXPECT().GetServiceLog(gomock.Eq(cluster), gomock.Eq("log_type='cluster-state-updates'")).Return(&servicelogsv1.ClusterLogsUUIDListResponse{}, nil)
231255

232-
_, gotErr := Investigate(r)
256+
result, gotErr := Investigate(r)
233257
Expect(gotErr).NotTo(HaveOccurred())
258+
Expect(result.ServiceLogPrepared.Performed).To(BeFalse())
259+
Expect(result.ServiceLogSent.Performed).To(BeFalse())
260+
Expect(result.LimitedSupportSet.Performed).To(BeFalse())
234261
})
235262
})
236263

@@ -247,8 +274,11 @@ var _ = Describe("chgm", func() {
247274
r.PdClient.(*pdmock.MockClient).EXPECT().EscalateIncidentWithNote(gomock.Any()).Return(nil)
248275
r.OcmClient.(*ocmmock.MockClient).EXPECT().GetServiceLog(gomock.Any(), gomock.Eq("log_type='cluster-state-updates'")).Return(&servicelogsv1.ClusterLogsUUIDListResponse{}, nil)
249276

250-
_, gotErr := Investigate(r)
277+
result, gotErr := Investigate(r)
251278
Expect(gotErr).NotTo(HaveOccurred())
279+
Expect(result.ServiceLogPrepared.Performed).To(BeFalse())
280+
Expect(result.ServiceLogSent.Performed).To(BeFalse())
281+
Expect(result.LimitedSupportSet.Performed).To(BeFalse())
252282
})
253283
})
254284

@@ -265,8 +295,11 @@ var _ = Describe("chgm", func() {
265295
r.PdClient.(*pdmock.MockClient).EXPECT().EscalateIncidentWithNote(gomock.Any()).Return(nil)
266296
r.OcmClient.(*ocmmock.MockClient).EXPECT().GetServiceLog(gomock.Eq(cluster), gomock.Eq("log_type='cluster-state-updates'")).Return(&servicelogsv1.ClusterLogsUUIDListResponse{}, nil)
267297

268-
_, gotErr := Investigate(r)
298+
result, gotErr := Investigate(r)
269299
Expect(gotErr).NotTo(HaveOccurred())
300+
Expect(result.ServiceLogPrepared.Performed).To(BeFalse())
301+
Expect(result.ServiceLogSent.Performed).To(BeFalse())
302+
Expect(result.LimitedSupportSet.Performed).To(BeFalse())
270303
})
271304
})
272305
When("issuer user is authorized (customprefix-Installer-Role)", func() {
@@ -282,8 +315,11 @@ var _ = Describe("chgm", func() {
282315
r.PdClient.(*pdmock.MockClient).EXPECT().EscalateIncidentWithNote(gomock.Any()).Return(nil)
283316
r.OcmClient.(*ocmmock.MockClient).EXPECT().GetServiceLog(gomock.Eq(cluster), gomock.Eq("log_type='cluster-state-updates'")).Return(&servicelogsv1.ClusterLogsUUIDListResponse{}, nil)
284317

285-
_, gotErr := Investigate(r)
318+
result, gotErr := Investigate(r)
286319
Expect(gotErr).NotTo(HaveOccurred())
320+
Expect(result.ServiceLogPrepared.Performed).To(BeFalse())
321+
Expect(result.ServiceLogSent.Performed).To(BeFalse())
322+
Expect(result.LimitedSupportSet.Performed).To(BeFalse())
287323
})
288324
})
289325
When("issuer user is authorized (ManagedOpenShift-Support-.*)", func() {
@@ -299,8 +335,11 @@ var _ = Describe("chgm", func() {
299335
r.PdClient.(*pdmock.MockClient).EXPECT().EscalateIncidentWithNote(gomock.Any()).Return(nil)
300336
r.OcmClient.(*ocmmock.MockClient).EXPECT().GetServiceLog(gomock.Eq(cluster), gomock.Eq("log_type='cluster-state-updates'")).Return(&servicelogsv1.ClusterLogsUUIDListResponse{}, nil)
301337

302-
_, gotErr := Investigate(r)
338+
result, gotErr := Investigate(r)
303339
Expect(gotErr).NotTo(HaveOccurred())
340+
Expect(result.ServiceLogPrepared.Performed).To(BeFalse())
341+
Expect(result.ServiceLogSent.Performed).To(BeFalse())
342+
Expect(result.LimitedSupportSet.Performed).To(BeFalse())
304343
})
305344
})
306345
When("issuer user is authorized (.*-Support-Role)", func() {
@@ -316,8 +355,11 @@ var _ = Describe("chgm", func() {
316355
r.PdClient.(*pdmock.MockClient).EXPECT().EscalateIncidentWithNote(gomock.Any()).Return(nil)
317356
r.OcmClient.(*ocmmock.MockClient).EXPECT().GetServiceLog(gomock.Eq(cluster), gomock.Eq("log_type='cluster-state-updates'")).Return(&servicelogsv1.ClusterLogsUUIDListResponse{}, nil)
318357

319-
_, gotErr := Investigate(r)
358+
result, gotErr := Investigate(r)
320359
Expect(gotErr).NotTo(HaveOccurred())
360+
Expect(result.ServiceLogPrepared.Performed).To(BeFalse())
361+
Expect(result.ServiceLogSent.Performed).To(BeFalse())
362+
Expect(result.LimitedSupportSet.Performed).To(BeFalse())
321363
})
322364
})
323365
When("the returned CloudTrailEvent has a matching whitelisted user (osdManagedAdmin-.*)", func() {
@@ -333,8 +375,11 @@ var _ = Describe("chgm", func() {
333375
r.PdClient.(*pdmock.MockClient).EXPECT().EscalateIncidentWithNote(gomock.Any()).Return(nil)
334376
r.OcmClient.(*ocmmock.MockClient).EXPECT().GetServiceLog(gomock.Eq(cluster), gomock.Eq("log_type='cluster-state-updates'")).Return(&servicelogsv1.ClusterLogsUUIDListResponse{}, nil)
335377

336-
_, gotErr := Investigate(r)
378+
result, gotErr := Investigate(r)
337379
Expect(gotErr).NotTo(HaveOccurred())
380+
Expect(result.ServiceLogPrepared.Performed).To(BeFalse())
381+
Expect(result.ServiceLogSent.Performed).To(BeFalse())
382+
Expect(result.LimitedSupportSet.Performed).To(BeFalse())
338383
})
339384
})
340385
When("the returned CloudTrailEvent has a matching whitelisted user (osdCcsAdmin)", func() {
@@ -350,8 +395,11 @@ var _ = Describe("chgm", func() {
350395
r.PdClient.(*pdmock.MockClient).EXPECT().EscalateIncidentWithNote(gomock.Any()).Return(nil)
351396
r.OcmClient.(*ocmmock.MockClient).EXPECT().GetServiceLog(gomock.Eq(cluster), gomock.Eq("log_type='cluster-state-updates'")).Return(&servicelogsv1.ClusterLogsUUIDListResponse{}, nil)
352397

353-
_, gotErr := Investigate(r)
398+
result, gotErr := Investigate(r)
354399
Expect(gotErr).NotTo(HaveOccurred())
400+
Expect(result.ServiceLogPrepared.Performed).To(BeFalse())
401+
Expect(result.ServiceLogSent.Performed).To(BeFalse())
402+
Expect(result.LimitedSupportSet.Performed).To(BeFalse())
355403
})
356404
})
357405
When("the returned CloudTrailEvent has a matching whitelisted user (.*openshift-machine-api-awsv2.*)", func() {
@@ -367,8 +415,11 @@ var _ = Describe("chgm", func() {
367415
r.PdClient.(*pdmock.MockClient).EXPECT().EscalateIncidentWithNote(gomock.Any()).Return(nil)
368416
r.OcmClient.(*ocmmock.MockClient).EXPECT().GetServiceLog(gomock.Eq(cluster), gomock.Eq("log_type='cluster-state-updates'")).Return(&servicelogsv1.ClusterLogsUUIDListResponse{}, nil)
369417

370-
_, gotErr := Investigate(r)
418+
result, gotErr := Investigate(r)
371419
Expect(gotErr).NotTo(HaveOccurred())
420+
Expect(result.ServiceLogPrepared.Performed).To(BeFalse())
421+
Expect(result.ServiceLogSent.Performed).To(BeFalse())
422+
Expect(result.LimitedSupportSet.Performed).To(BeFalse())
372423
})
373424
})
374425
When("the returned CloudTrailEventRaw has an empty userIdentity", func() {
@@ -381,8 +432,11 @@ var _ = Describe("chgm", func() {
381432
r.OcmClient.(*ocmmock.MockClient).EXPECT().PostServiceLog(gomock.Eq(cluster.ID()), gomock.Eq(&chgmSL)).Return(nil)
382433
r.PdClient.(*pdmock.MockClient).EXPECT().SilenceIncidentWithNote(gomock.Any()).Return(nil)
383434

384-
_, gotErr := Investigate(r)
435+
result, gotErr := Investigate(r)
385436
Expect(gotErr).NotTo(HaveOccurred())
437+
Expect(result.ServiceLogPrepared.Performed).To(BeFalse())
438+
Expect(result.ServiceLogSent.Performed).To(BeTrue())
439+
Expect(result.LimitedSupportSet.Performed).To(BeFalse())
386440
})
387441
})
388442
When("issuer user is unauthorized (testuser assumed role)", func() {
@@ -395,8 +449,11 @@ var _ = Describe("chgm", func() {
395449
r.OcmClient.(*ocmmock.MockClient).EXPECT().PostServiceLog(gomock.Eq(cluster.ID()), gomock.Eq(&chgmSL)).Return(nil)
396450
r.PdClient.(*pdmock.MockClient).EXPECT().SilenceIncidentWithNote(gomock.Any()).Return(nil)
397451

398-
_, gotErr := Investigate(r)
452+
result, gotErr := Investigate(r)
399453
Expect(gotErr).NotTo(HaveOccurred())
454+
Expect(result.ServiceLogPrepared.Performed).To(BeFalse())
455+
Expect(result.ServiceLogSent.Performed).To(BeTrue())
456+
Expect(result.LimitedSupportSet.Performed).To(BeFalse())
400457
})
401458
})
402459
When("the returned CloudTrailEventRaw base data is correct, but the sessionissue's role is not role", func() {
@@ -409,8 +466,11 @@ var _ = Describe("chgm", func() {
409466
r.OcmClient.(*ocmmock.MockClient).EXPECT().PostServiceLog(gomock.Eq(cluster.ID()), gomock.Eq(&chgmSL)).Return(nil)
410467
r.PdClient.(*pdmock.MockClient).EXPECT().SilenceIncidentWithNote(gomock.Any()).Return(nil)
411468

412-
_, gotErr := Investigate(r)
469+
result, gotErr := Investigate(r)
413470
Expect(gotErr).NotTo(HaveOccurred())
471+
Expect(result.ServiceLogPrepared.Performed).To(BeFalse())
472+
Expect(result.ServiceLogSent.Performed).To(BeTrue())
473+
Expect(result.LimitedSupportSet.Performed).To(BeFalse())
414474
})
415475
})
416476
When("the returned CloudTrailEventRaw has no data", func() {
@@ -422,8 +482,11 @@ var _ = Describe("chgm", func() {
422482
r.OcmClient.(*ocmmock.MockClient).EXPECT().PostServiceLog(gomock.Eq(cluster.ID()), gomock.Eq(&chgmSL)).Return(nil)
423483
r.PdClient.(*pdmock.MockClient).EXPECT().SilenceIncidentWithNote(gomock.Any()).Return(nil)
424484

425-
_, gotErr := Investigate(r)
485+
result, gotErr := Investigate(r)
426486
Expect(gotErr).NotTo(HaveOccurred())
487+
Expect(result.ServiceLogPrepared.Performed).To(BeFalse())
488+
Expect(result.ServiceLogSent.Performed).To(BeTrue())
489+
Expect(result.LimitedSupportSet.Performed).To(BeFalse())
427490
})
428491
})
429492

@@ -437,8 +500,11 @@ var _ = Describe("chgm", func() {
437500
r.OcmClient.(*ocmmock.MockClient).EXPECT().PostServiceLog(gomock.Eq(cluster.ID()), gomock.Eq(&chgmSL)).Return(nil)
438501
r.PdClient.(*pdmock.MockClient).EXPECT().SilenceIncidentWithNote(gomock.Any()).Return(nil)
439502

440-
_, gotErr := Investigate(r)
503+
result, gotErr := Investigate(r)
441504
Expect(gotErr).NotTo(HaveOccurred())
505+
Expect(result.ServiceLogPrepared.Performed).To(BeFalse())
506+
Expect(result.ServiceLogSent.Performed).To(BeTrue())
507+
Expect(result.LimitedSupportSet.Performed).To(BeFalse())
442508
})
443509
})
444510

@@ -452,8 +518,11 @@ var _ = Describe("chgm", func() {
452518
r.OcmClient.(*ocmmock.MockClient).EXPECT().PostServiceLog(gomock.Eq(cluster.ID()), gomock.Eq(&chgmSL)).Return(nil)
453519
r.PdClient.(*pdmock.MockClient).EXPECT().SilenceIncidentWithNote(gomock.Any()).Return(nil)
454520

455-
_, gotErr := Investigate(r)
521+
result, gotErr := Investigate(r)
456522
Expect(gotErr).NotTo(HaveOccurred())
523+
Expect(result.ServiceLogPrepared.Performed).To(BeFalse())
524+
Expect(result.ServiceLogSent.Performed).To(BeTrue())
525+
Expect(result.LimitedSupportSet.Performed).To(BeFalse())
457526
})
458527
})
459528
When("the returned CloudTrailEvent has more than one resource", func() {
@@ -467,8 +536,11 @@ var _ = Describe("chgm", func() {
467536
r.AwsClient.(*awsmock.MockClient).EXPECT().PollInstanceStopEventsFor(gomock.Any(), gomock.Any()).Return([]cloudtrailv2types.Event{event}, nil)
468537
r.PdClient.(*pdmock.MockClient).EXPECT().EscalateIncidentWithNote(gomock.Any()).Return(nil)
469538

470-
_, gotErr := Investigate(r)
539+
result, gotErr := Investigate(r)
471540
Expect(gotErr).NotTo(HaveOccurred())
541+
Expect(result.ServiceLogPrepared.Performed).To(BeFalse())
542+
Expect(result.ServiceLogSent.Performed).To(BeFalse())
543+
Expect(result.LimitedSupportSet.Performed).To(BeFalse())
472544
})
473545
})
474546
When("the returned CloudTrailEvent is empty", func() {
@@ -482,8 +554,11 @@ var _ = Describe("chgm", func() {
482554
r.AwsClient.(*awsmock.MockClient).EXPECT().PollInstanceStopEventsFor(gomock.Any(), gomock.Any()).Return([]cloudtrailv2types.Event{}, nil)
483555
r.PdClient.(*pdmock.MockClient).EXPECT().EscalateIncidentWithNote(gomock.Any()).Return(nil)
484556

485-
_, gotErr := Investigate(r)
557+
result, gotErr := Investigate(r)
486558
Expect(gotErr).NotTo(HaveOccurred())
559+
Expect(result.ServiceLogPrepared.Performed).To(BeFalse())
560+
Expect(result.ServiceLogSent.Performed).To(BeFalse())
561+
Expect(result.LimitedSupportSet.Performed).To(BeFalse())
487562
})
488563
})
489564
When("the returned CloudTrailEvent is an empty string", func() {
@@ -497,8 +572,11 @@ var _ = Describe("chgm", func() {
497572
r.AwsClient.(*awsmock.MockClient).EXPECT().PollInstanceStopEventsFor(gomock.Any(), gomock.Any()).Return([]cloudtrailv2types.Event{event}, nil)
498573
r.PdClient.(*pdmock.MockClient).EXPECT().EscalateIncidentWithNote(gomock.Any()).Return(nil)
499574

500-
_, gotErr := Investigate(r)
575+
result, gotErr := Investigate(r)
501576
Expect(gotErr).NotTo(HaveOccurred())
577+
Expect(result.ServiceLogPrepared.Performed).To(BeFalse())
578+
Expect(result.ServiceLogSent.Performed).To(BeFalse())
579+
Expect(result.LimitedSupportSet.Performed).To(BeFalse())
502580
})
503581
})
504582
When("the returned CloudTrailEvent is an empty json", func() {
@@ -512,8 +590,11 @@ var _ = Describe("chgm", func() {
512590
r.AwsClient.(*awsmock.MockClient).EXPECT().PollInstanceStopEventsFor(gomock.Any(), gomock.Any()).Return([]cloudtrailv2types.Event{event}, nil)
513591
r.PdClient.(*pdmock.MockClient).EXPECT().EscalateIncidentWithNote(gomock.Any()).Return(nil)
514592

515-
_, gotErr := Investigate(r)
593+
result, gotErr := Investigate(r)
516594
Expect(gotErr).NotTo(HaveOccurred())
595+
Expect(result.ServiceLogPrepared.Performed).To(BeFalse())
596+
Expect(result.ServiceLogSent.Performed).To(BeFalse())
597+
Expect(result.LimitedSupportSet.Performed).To(BeFalse())
517598
})
518599
})
519600
When("the returned CloudTrailEvent is an invalid json", func() {
@@ -527,8 +608,11 @@ var _ = Describe("chgm", func() {
527608
r.AwsClient.(*awsmock.MockClient).EXPECT().PollInstanceStopEventsFor(gomock.Any(), gomock.Any()).Return([]cloudtrailv2types.Event{event}, nil)
528609
r.PdClient.(*pdmock.MockClient).EXPECT().EscalateIncidentWithNote(gomock.Any()).Return(nil)
529610

530-
_, gotErr := Investigate(r)
611+
result, gotErr := Investigate(r)
531612
Expect(gotErr).NotTo(HaveOccurred())
613+
Expect(result.ServiceLogPrepared.Performed).To(BeFalse())
614+
Expect(result.ServiceLogSent.Performed).To(BeFalse())
615+
Expect(result.LimitedSupportSet.Performed).To(BeFalse())
532616
})
533617
})
534618
})

0 commit comments

Comments
 (0)