Skip to content

Commit 8b46e78

Browse files
committed
add comment to k8s client handling
1 parent b1be4e1 commit 8b46e78

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

pkg/investigations/clustermonitoringerrorbudgetburn/clustermonitoringerrorbudgetburn.go

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,11 @@ var uwmMisconfiguredSL = ocm.ServiceLog{
2727

2828
func Investigate(r *investigation.Resources) (investigation.InvestigationResult, error) {
2929
// Initialize k8s client
30+
// This would be better suited to be passend in with the investigation resources
31+
// In turn we would need to split out ccam and k8sclient, as those are tied to a cluster
32+
// Failing the cleanup call is not critical as there is garbage collection for the RBAC within MCC https://issues.redhat.com/browse/OSD-27692
33+
// We can revisit backplane-apis remediation implementation to improve this behavior, by e.g.
34+
// patching the existing RBAC etc...
3035
result := investigation.InvestigationResult{}
3136
k8scli, err := k8sclient.New(r.Cluster.ID(), r.OcmClient, r.Name)
3237
if err != nil {

0 commit comments

Comments
 (0)