Do not call a precheck an investigation.

Author: bergmannf

cadctl/cmd/investigate/investigate.go

@@ -125,7 +125,7 @@ func run(cmd *cobra.Command, _ []string) error {
 		return investigationErr
 	}
 
-	precheck := precheck.Investigation{}
+	precheck := precheck.ClusterStatePrecheck{}
 	result, err := precheck.Run(builder)
 	if err = handleClusterNotFound(err); err != nil || result.StopInvestigations {
 		return err

pkg/investigations/precheck/precheck.go

@@ -6,13 +6,13 @@ import (
 	"github.com/openshift/configuration-anomaly-detection/pkg/logging"
 )
 
-type Investigation struct{}
+type ClusterStatePrecheck struct{}
 
 // Checks pre-requisites for a cluster investigation:
 // - the cluster's state is supported by CAD for an investigation (= not uninstalling)
 // - the cloud provider is supported by CAD (cluster is AWS)
 // Performs according pagerduty actions and returns whether CAD needs to investigate the cluster
-func (c *Investigation) Run(rb investigation.ResourceBuilder) (investigation.InvestigationResult, error) {
+func (c *ClusterStatePrecheck) Run(rb investigation.ResourceBuilder) (investigation.InvestigationResult, error) {
 	result := investigation.InvestigationResult{}
 	r, err := rb.Build()
 	if err != nil {

pkg/investigations/precheck/precheck_test.go

@@ -20,14 +20,14 @@ func TestInvestigation_Run(t *testing.T) {
 	}
 	tests := []struct {
 		name    string
-		c       *Investigation
+		c       *ClusterStatePrecheck
 		args    args
 		want    investigation.InvestigationResult
 		wantErr bool
 	}{
 		{
 			"cloud provider unsupported stops investigation",
-			&Investigation{},
+			&ClusterStatePrecheck{},
 			args{rb: &investigation.ResourceBuilderMock{
 				Resources: &investigation.Resources{
 					Cluster:   &cmv1.Cluster{},
@@ -41,7 +41,7 @@ func TestInvestigation_Run(t *testing.T) {
 	}
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
-			c := &Investigation{}
+			c := &ClusterStatePrecheck{}
 			got, err := c.Run(tt.args.rb)
 			if (err != nil) != tt.wantErr {
 				t.Errorf("Investigation.Run() error = %v, wantErr %v", err, tt.wantErr)