Skip to content

Commit cce0843

Browse files
committed
Deprecate x-secret-token
1 parent 14e1e85 commit cce0843

File tree

4 files changed

+2
-16
lines changed

4 files changed

+2
-16
lines changed

README.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -168,7 +168,6 @@ Grafana dashboard configmaps are stored in the [Dashboards](./dashboards/) direc
168168
* `CAD_PD_USERNAME`: refers to the username of CAD on PagerDuty
169169
* `CAD_SILENT_POLICY`: refers to the silent policy CAD should use if the incident shall be silent
170170
* `PD_SIGNATURE`: refers to the PagerDuty webhook signature (HMAC+SHA256)
171-
* `X_SECRET_TOKEN`: refers to our custom Secret Token for authenticating against our pipeline
172171
* `CAD_PROMETHEUS_PUSHGATEWAY`: refers to the URL cad will push metrics to
173172
* `BACKPLANE_URL`: refers to the backplane url to use
174173
* `BACKPLANE_INITIAL_ARN`: refers to the initial ARN used for the isolated backplane jumprole flow

deploy/pipeline-trigger.yaml

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -40,11 +40,6 @@ metadata:
4040
name: cad-pipe-listener
4141
spec:
4242
interceptors:
43-
- ref:
44-
name: "cel"
45-
params:
46-
- name: "filter"
47-
value: "header.canonical('X-Secret-Token').compareSecret('X_SECRET_TOKEN', 'cad-pd-token')"
4843
# Enable after interceptor deployment is tested
4944
- ref:
5045
name: "cad-interceptor"
@@ -88,4 +83,4 @@ spec:
8883
valueFrom:
8984
secretKeyRef:
9085
key: tls.key
91-
name: cad-event-listener-tls-secret
86+
name: cad-event-listener-tls-secret

deploy/task-cad-checks-secrets-pd.yaml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,5 +10,4 @@ stringData:
1010
CAD_PD_TOKEN: CHANGEME # refers to the generated private access token for token-based authentication
1111
CAD_PD_USERNAME: CHANGEME # refers to the username in case username/pw credentials should be used
1212
CAD_SILENT_POLICY: CHANGEME # refers to the silent policy CAD should use if the incident shall be silent
13-
X_SECRET_TOKEN: CHANGEME # refers to the PagerDuty webhook signature (HMAC+SHA256)
14-
PD_SIGNATURE: CHANGEME # refers to our custom Secret Token for authenticating against our pipeline
13+
PD_SIGNATURE: CHANGEME # refers to our custom Secret Token for authenticating against our pipeline

openshift/template.yaml

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -145,12 +145,6 @@ objects:
145145
bindings:
146146
- ref: cad-check-trigger
147147
interceptors:
148-
- params:
149-
- name: filter
150-
value: header.canonical('X-Secret-Token').compareSecret('X_SECRET_TOKEN',
151-
'cad-pd-token')
152-
ref:
153-
name: cel
154148
- ref:
155149
kind: NamespacedInterceptor
156150
name: cad-interceptor
@@ -289,7 +283,6 @@ objects:
289283
CAD_PD_USERNAME: CHANGEME
290284
CAD_SILENT_POLICY: CHANGEME
291285
PD_SIGNATURE: CHANGEME
292-
X_SECRET_TOKEN: CHANGEME
293286
type: Opaque
294287
- apiVersion: tekton.dev/v1beta1
295288
kind: Task

0 commit comments

Comments
 (0)