Skip to content

Commit 7e52f16

Browse files
Merge pull request #902 from theobarberbany/fix-error-verbs
OCPBUGS-31777: Updates message verbs to use %q where appropriate.
2 parents 2ec56b1 + 0089dec commit 7e52f16

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

pkg/cmd/crdconversionwebhook/converter/framework.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -78,13 +78,13 @@ func serve(w http.ResponseWriter, r *http.Request, convert convertFunc) {
7878
contentType := r.Header.Get("Content-Type")
7979
serializer := getInputSerializer(contentType)
8080
if serializer == nil {
81-
msg := fmt.Sprintf("invalid Content-Type header `%s`", contentType)
81+
msg := fmt.Sprintf("invalid Content-Type header %q", contentType)
8282
klog.Errorf(msg)
8383
http.Error(w, msg, http.StatusBadRequest)
8484
return
8585
}
8686

87-
klog.V(4).Infof("Handling request body: \n%v", string(body))
87+
klog.V(4).Infof("Handling request body: \n%q", string(body))
8888
obj, gvk, err := serializer.Decode(body, nil, nil)
8989
if err != nil {
9090
msg := fmt.Sprintf("failed to deserialize body (%v) with error %v", string(body), err)
@@ -117,7 +117,7 @@ func serve(w http.ResponseWriter, r *http.Request, convert convertFunc) {
117117
accept := r.Header.Get("Accept")
118118
outSerializer := getOutputSerializer(accept)
119119
if outSerializer == nil {
120-
msg := fmt.Sprintf("invalid accept header `%s`", accept)
120+
msg := fmt.Sprintf("invalid accept header %q", accept)
121121
klog.Errorf(msg)
122122
http.Error(w, msg, http.StatusBadRequest)
123123
return
@@ -130,7 +130,7 @@ func serve(w http.ResponseWriter, r *http.Request, convert convertFunc) {
130130
http.Error(w, err.Error(), http.StatusInternalServerError)
131131
return
132132
}
133-
klog.V(4).Infof("Sending response: \n%v", responseBuffer.String())
133+
klog.V(4).Infof("Sending response: \n%q", responseBuffer.String())
134134
w.Write(responseBuffer.Bytes())
135135
}
136136

0 commit comments

Comments
 (0)