Skip to content

Commit 7fd4ec6

Browse files
committed
OCPBUGS-55425: remove the make build cross rule and add build rule, update README.
1 parent 29d3072 commit 7fd4ec6

File tree

2 files changed

+7
-6
lines changed

2 files changed

+7
-6
lines changed

Makefile

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,8 @@ check: | verify test-unit
1818

1919
IMAGE_REGISTRY?=registry.svc.ci.openshift.org
2020

21+
TAGS ?= ocp
22+
2123
# This will call a macro called "build-image" which will generate image specific targets based on the parameters:
2224
# $0 - macro name
2325
# $1 - target name
@@ -37,6 +39,9 @@ $(call add-profile-manifests,manifests,./profile-patches,./manifests)
3739

3840
GO_UNIT_TEST_PACKAGES :=./pkg/... ./cmd/...
3941

42+
build:
43+
go build -tags '$(TAGS)' -o $@ ./cmd/console/main.go
44+
4045
# Run tests
4146
test: test-unit test-e2e
4247

README.md

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -159,15 +159,11 @@ Now we should be ready to build & deploy the operator with our changes.
159159

160160
#### Preparation to Deploy Operator Changes Quickly
161161

162-
Typically to build your binary you will use the `make` command:
162+
Typically to build your binary you would use the `make` command:
163163

164164
```bash
165-
# this will build for your platform:
165+
# this will build locally:
166166
make
167-
# if you are running OSX, you will need to build for linux doing something like:
168-
OS_DEBUG=true OS_BUILD_PLATFORMS=linux/amd64 make
169-
# note that you can build for mulitiple platforms with:
170-
make build-cross
171167
```
172168
But the build step is included in the `Dockerfile.rhel7`, so this does not need to be done manually.
173169
You can instead simply build the container image and push it to your own registry:

0 commit comments

Comments
 (0)