Skip to content

Do not log readinessProbe and livenessProbe requests #1051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Do not log readinessProbe and livenessProbe requests #1051

wants to merge 1 commit into from

Conversation

cfelder
Copy link

@cfelder cfelder commented Oct 1, 2025

Requests to the 'OpenShift Downloads Server' are sent every 10s
configured in the readinessProbe and livenessProbe in the
downloads deployment. Previously those requests have been logged
accumulating gigabytes of log output over time. This patch introduces an
endpoint /healthz used for readinessProbe and livenessProbe w/o
logging.

Signed-off-by: Christian Felder [email protected]

@cfelder
Do not log readinessProbe and livenessProbe requests
32e925d 
Requests to the 'OpenShift Downloads Server' are sent every 10s
configured in the `readinessProbe` and `livenessProbe` in the
`downloads` deployment. Previously those requests have been logged
accumulating gigabytes of log output over time. This patch introduces an
endpoint `/healthz` used for `readinessProbe` and `livenessProbe` w/o
logging.

Signed-off-by: Christian Felder <[email protected]>
@openshift-ci openshift-ci bot requested review from jhadvig and spadgett October 1, 2025 15:33
@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 1, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 1, 2025

Hi @cfelder. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jhadvig
Copy link
Member

jhadvig commented Oct 13, 2025

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 13, 2025
jhadvig
jhadvig approved these changes Oct 13, 2025
View reviewed changes
Copy link
Member

@jhadvig jhadvig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 13, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 13, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cfelder, jhadvig

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 13, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 13, 2025

@cfelder: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/unit 32e925d link true /test unit
ci/prow/e2e-aws-console 32e925d link true /test e2e-aws-console

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jhadvig jhadvig jhadvig approved these changes

@spadgett spadgett Awaiting requested review from spadgett

Assignees

@jhadvig jhadvig

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cfelder @jhadvig