Skip to content

Conversation

jmesnil
Copy link
Contributor

@jmesnil jmesnil commented Sep 9, 2024

This OpenShift Quickstart is similar to the one for JBoss EAP 7 (ODC-7312) but targets EAP 8 instead.

JIRA: https://issues.redhat.com/browse/ODC-7555

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 9, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 9, 2024

@jmesnil: This pull request references ODC-7555 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

This OpenShift Quickstart is similar to the one for JBoss EAP 7 (ODC-7312) but targets EAP 8 instead.

JIRA: https://issues.redhat.com/browse/ODC-7555

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

1 similar comment
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 9, 2024

@jmesnil: This pull request references ODC-7555 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

This OpenShift Quickstart is similar to the one for JBoss EAP 7 (ODC-7312) but targets EAP 8 instead.

JIRA: https://issues.redhat.com/browse/ODC-7555

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jmesnil
Copy link
Contributor Author

jmesnil commented Oct 4, 2024

/retest

@jhadvig
Copy link
Member

jhadvig commented Oct 4, 2024

/lgtm
/approve

@opayne1 could you please take a look at this QuickStart. :)

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 4, 2024
Copy link
Contributor

@opayne1 opayne1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just had a few comments.


1. In the navigation menu, click [Topology]{{highlight qs-nav-topology}}.
In the Topology view, the **eap8** deployment displays a code icon in the bottom right-hand corner. This icon either represents the Git repository
of the associated code, or if the appropriate operators are installed, it will bring up the associated code in your IDE.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
of the associated code, or if the appropriate operators are installed, it will bring up the associated code in your IDE.
of the associated code, or if the appropriate operators are installed, it will open the associated code in your IDE.

@openshift-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 6, 2025
@openshift-bot
Copy link
Contributor

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Feb 5, 2025
@jmesnil
Copy link
Contributor Author

jmesnil commented Feb 18, 2025

/retest-required

@jhadvig
Copy link
Member

jhadvig commented Feb 18, 2025

/lgtm cancel
@jmesnil could you please address first @opayne1 comments? Thank you :)

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 18, 2025
Copy link
Contributor

openshift-ci bot commented Feb 18, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jmesnil
Once this PR has been reviewed and has the lgtm label, please ask for approval from jhadvig. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 18, 2025
This OpenShift Quickstart is similar to the one for
JBoss EAP 7 (ODC-7312) but targets EAP 8 instead.

JIRA: https://issues.redhat.com/browse/ODC-7555

Signed-off-by: Jeff Mesnil <[email protected]>
@jmesnil jmesnil force-pushed the ODC-7555_quickstart_jboss_eap8 branch from a3a4859 to 829f308 Compare February 18, 2025 11:59
@jmesnil
Copy link
Contributor Author

jmesnil commented Feb 18, 2025

@jhadvig Sorry, I forgot to push my amended commit. I've resolved all @opayne1 suggestions. thanks!

@opayne1
Copy link
Contributor

opayne1 commented Feb 19, 2025

Thanks for the updates.

/label docs-approved

@openshift-ci openshift-ci bot added the docs-approved Signifies that Docs has signed off on this PR label Feb 19, 2025
@openshift-bot
Copy link
Contributor

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

@openshift-ci openshift-ci bot closed this Mar 22, 2025
Copy link
Contributor

openshift-ci bot commented Mar 22, 2025

@openshift-bot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jmesnil
Copy link
Contributor Author

jmesnil commented May 15, 2025

/reopen.

This feature is still valid and something we want to do

@vikram-raj
Copy link
Member

/reopen
/remove-lifecycle rotten

@openshift-ci openshift-ci bot reopened this Aug 20, 2025
Copy link
Contributor

openshift-ci bot commented Aug 20, 2025

@vikram-raj: Reopened this PR.

In response to this:

/reopen
/remove-lifecycle rotten

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 20, 2025

@jmesnil: This pull request references ODC-7555 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

This OpenShift Quickstart is similar to the one for JBoss EAP 7 (ODC-7312) but targets EAP 8 instead.

JIRA: https://issues.redhat.com/browse/ODC-7555

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Aug 20, 2025
Copy link
Contributor

openshift-ci bot commented Aug 20, 2025

@jmesnil: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-single-node 829f308 link false /test e2e-aws-ovn-single-node
ci/prow/e2e-gcp-ovn 829f308 link true /test e2e-gcp-ovn
ci/prow/e2e-aws-console 829f308 link true /test e2e-aws-console
ci/prow/e2e-hypershift-conformance 829f308 link false /test e2e-hypershift-conformance

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@christoph-jerolimov
Copy link
Member

/uncc
/cc @jhadvig

@openshift-ci openshift-ci bot requested review from jhadvig and removed request for christoph-jerolimov August 20, 2025 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants