Skip to content

Commit 8afa224

Browse files
author
shiftstack-merge-bot
committed
2 parents 49f2d86 + cab0d7d commit 8afa224

File tree

8 files changed

+19
-13
lines changed

8 files changed

+19
-13
lines changed

.github/workflows/trivy.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ jobs:
1515
- name: Install go
1616
uses: actions/setup-go@v6
1717
with:
18-
go-version: 1.24.9
18+
go-version: 1.24.11
1919

2020
- name: Build an image from Dockerfile
2121
run: |

charts/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515

1616
### install a specific version
1717
> [!IMPORTANT]
18-
> Starting from version `4.11.0`, the prefix `v` is removed from hlem chart release so they are in line with [semver](https://semver.org). Therefore, when upgrading, refer to version `4.11.0` instead of `v4.11.0`.
18+
> Starting from version `4.11.0`, the prefix `v` is removed from helm chart release so they are in line with [semver](https://semver.org). Therefore, when upgrading, refer to version `4.11.0` instead of `v4.11.0`.
1919
2020
```console
2121
helm repo add csi-driver-nfs https://raw.githubusercontent.com/kubernetes-csi/csi-driver-nfs/master/charts
-4 Bytes
Binary file not shown.

charts/latest/csi-driver-nfs/values.yaml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -6,27 +6,27 @@ image:
66
tag: canary
77
pullPolicy: IfNotPresent
88
csiProvisioner:
9-
repository: registry.k8s.io/sig-storage/csi-provisioner
9+
repository: /sig-storage/csi-provisioner
1010
tag: v6.0.0
1111
pullPolicy: IfNotPresent
1212
csiResizer:
13-
repository: registry.k8s.io/sig-storage/csi-resizer
13+
repository: /sig-storage/csi-resizer
1414
tag: v2.0.0
1515
pullPolicy: IfNotPresent
1616
csiSnapshotter:
17-
repository: registry.k8s.io/sig-storage/csi-snapshotter
17+
repository: /sig-storage/csi-snapshotter
1818
tag: v8.4.0
1919
pullPolicy: IfNotPresent
2020
livenessProbe:
21-
repository: registry.k8s.io/sig-storage/livenessprobe
21+
repository: /sig-storage/livenessprobe
2222
tag: v2.17.0
2323
pullPolicy: IfNotPresent
2424
nodeDriverRegistrar:
25-
repository: registry.k8s.io/sig-storage/csi-node-driver-registrar
25+
repository: /sig-storage/csi-node-driver-registrar
2626
tag: v2.15.0
2727
pullPolicy: IfNotPresent
2828
externalSnapshotter:
29-
repository: registry.k8s.io/sig-storage/snapshot-controller
29+
repository: /sig-storage/snapshot-controller
3030
tag: v8.4.0
3131
pullPolicy: IfNotPresent
3232

deploy/example/nfs-provisioner/nginx-pod.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ spec:
1616
- nfsvers=4.1
1717
csi:
1818
driver: nfs.csi.k8s.io
19-
# volumeHandle format: {nfs-server-address}#{sub-dir-name}#{share-name}
19+
# volumeHandle format: {nfs-server-address}#{share-name}#{sub-dir-name}
2020
# make sure this value is unique for every share in the cluster
2121
volumeHandle: nfs-server.default.svc.cluster.local/share##
2222
volumeAttributes:

deploy/example/pv-nfs-csi.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ spec:
1616
- nfsvers=4.1
1717
csi:
1818
driver: nfs.csi.k8s.io
19-
# volumeHandle format: {nfs-server-address}#{sub-dir-name}#{share-name}
19+
# volumeHandle format: {nfs-server-address}#{share-name}#{sub-dir-name}
2020
# make sure this value is unique for every share in the cluster
2121
volumeHandle: nfs-server.default.svc.cluster.local/share##
2222
volumeAttributes:

docs/driver-parameters.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ onDelete | when volume is deleted, keep the directory if it's `retain` | `delete
1414

1515
- VolumeID(`volumeHandle`) is the identifier of the volume handled by the driver, format of VolumeID:
1616
```
17-
{nfs-server-address}#{sub-dir-name}#{share-name}
17+
{nfs-server-address}#{share-name}#{sub-dir-name}
1818
```
1919
> example: `nfs-server.default.svc.cluster.local/share#subdir#`
2020
@@ -23,7 +23,7 @@ onDelete | when volume is deleted, keep the directory if it's `retain` | `delete
2323
2424
Name | Meaning | Example Value | Mandatory | Default value
2525
--- | --- | --- | --- | ---
26-
volumeHandle | Specify a value the driver can use to uniquely identify the share in the cluster. | A recommended way to produce a unique value is to combine the nfs-server address, sub directory name and share name: `{nfs-server-address}#{sub-dir-name}#{share-name}`. | Yes |
26+
volumeHandle | Specify a value the driver can use to uniquely identify the share in the cluster. | A recommended way to produce a unique value is to combine the nfs-server address, sub directory name and share name: `{nfs-server-address}#{share-name}#{sub-dir-name}`. | Yes |
2727
volumeAttributes.server | NFS Server address | domain name `nfs-server.default.svc.cluster.local` <br>or IP address `127.0.0.1` | Yes |
2828
volumeAttributes.share | NFS share path | `/` | Yes |
2929
volumeAttributes.mountPermissions | mounted folder permissions. The default is `0`, if set as non-zero, driver will perform `chmod` after mount | | No |

hack/verify-helm-chart.sh

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,13 @@ function get_image_from_helm_chart() {
2222
local -r image_name="${1}"
2323
image_repository="$(cat ${PKG_ROOT}/charts/latest/csi-driver-nfs/values.yaml | yq -r .image.${image_name}.repository)"
2424
image_tag="$(cat ${PKG_ROOT}/charts/latest/csi-driver-nfs/values.yaml | yq -r .image.${image_name}.tag)"
25-
echo "${image_repository}:${image_tag}"
25+
# If repository starts with /, prepend baseRepo
26+
if [[ "${image_repository}" == /* ]]; then
27+
base_repo="$(cat ${PKG_ROOT}/charts/latest/csi-driver-nfs/values.yaml | yq -r .image.baseRepo)"
28+
echo "${base_repo}${image_repository}:${image_tag}"
29+
else
30+
echo "${image_repository}:${image_tag}"
31+
fi
2632
}
2733

2834
function validate_image() {

0 commit comments

Comments
 (0)