Skip to content

Conversation

@rexagod
Copy link
Member

@rexagod rexagod commented Oct 28, 2025

Goes over the details for the OptionalMonitoring capability, which targets putting the in-cluster monitoring stack in a telemetry-only state. Note that the metric targets are not modified under this capability itself, but only when the telemetry collection profile is enabled.

Goes over the details for the `OptionalMonitoring` capability, which
targets putting the in-cluster monitoring stack in a telemetry-only
state. Note that the metric targets are not modified under this
capability itself, but only when the telemetry collection profile is
enabled.
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 28, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 28, 2025

@rexagod: This pull request references MON-4414 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.21.0" version, but no target version was set.

In response to this:

Goes over the details for the OptionalMonitoring capability, which targets putting the in-cluster monitoring stack in a telemetry-only state. Note that the metric targets are not modified under this capability itself, but only when the telemetry collection profile is enabled.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 28, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 28, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 28, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign simonpasquier for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rexagod rexagod changed the title MON-4414: OEP for optional monitoring MON-4414: Optional Monitoring Capability Nov 3, 2025
@rexagod rexagod marked this pull request as ready for review November 3, 2025 21:03
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 3, 2025
@openshift-ci openshift-ci bot requested review from moadz and simonpasquier November 3, 2025 21:04
@simonpasquier
Copy link
Contributor

/unassign @moadz
/cc @jan--f

@openshift-ci openshift-ci bot requested a review from jan--f November 5, 2025 16:21
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 24, 2025

@rexagod: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Comment on lines +641 to +648
4. Should we downscale Prometheus to a single replica when the
capability is disabled?
> Yes, since the monitoring footprint is reduced significantly
when the capability is disabled, moving away from an HA setup
to a single replica setup makes sense from a resource consumption
perspective. All components across OpenShift that rely on Thanos
will need to be "taught" to query the single Prometheus replica
directly instead of going through Thanos Querier.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(noting here that in this case, we will not support Genie; PTAL at this discussion)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants