Skip to content

Commit 2b9c68b

Browse files
committed
ESO-2: Detects and reconciles changes to annotations in webhook resource
1 parent d17364d commit 2b9c68b

File tree

2 files changed

+7
-1
lines changed

2 files changed

+7
-1
lines changed

pkg/controller/common/utils.go

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -343,6 +343,12 @@ func validatingWebHookSpecModified(desired, fetched *webhook.ValidatingWebhookCo
343343
return true
344344
}
345345

346+
if desiredVal, exists := desired.GetAnnotations()[CertManagerInjectCAFromAnnotation]; exists {
347+
if desiredVal != fetched.GetAnnotations()[CertManagerInjectCAFromAnnotation] {
348+
return true
349+
}
350+
}
351+
346352
fetchedWebhooksMap := make(map[string]webhook.ValidatingWebhook)
347353
for _, wh := range fetched.Webhooks {
348354
fetchedWebhooksMap[wh.Name] = wh

pkg/controller/external_secrets/deployments.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,7 @@ func (r *Reconciler) getDeploymentObject(assetName string, externalsecrets *oper
126126
case certControllerDeploymentAssetName:
127127
updateCertControllerContainerSpec(deployment, image, logLevel)
128128
case bitwardenDeploymentAssetName:
129-
deployment.ObjectMeta.Labels["app.kubernetes.io/version"] = bitwardenImageVersionEnvVarName
129+
deployment.Labels["app.kubernetes.io/version"] = bitwardenImageVersionEnvVarName
130130
updateBitwardenServerContainerSpec(deployment, bitwardenImage)
131131
}
132132

0 commit comments

Comments
 (0)