ESO-155: fixes loop iteration to go through all volumes

bharath-b-rh · bharath-b-rh · commit c887dab0182e · 2025-10-14T15:30:51.000+05:30
Signed-off-by: Bharath B &lt;bhb@redhat.com&gt;
diff --git a/pkg/controller/external_secrets/deployments.go b/pkg/controller/external_secrets/deployments.go
@@ -420,9 +420,10 @@ func updateWebhookVolumeConfig(deployment *appsv1.Deployment, esc *operatorv1alp
 func updateSecretVolumeConfig(deployment *appsv1.Deployment, volumeName, secretName string) {
 	volumeExists := false
 	for i := range deployment.Spec.Template.Spec.Volumes {
-		if deployment.Spec.Template.Spec.Volumes[i].Name == volumeName {
-			volumeExists = true
+		if deployment.Spec.Template.Spec.Volumes[i].Name != volumeName {
+			continue
 		}
+		volumeExists = true
 		if deployment.Spec.Template.Spec.Volumes[i].Secret == nil {
 			deployment.Spec.Template.Spec.Volumes[i].Secret = &corev1.SecretVolumeSource{}
 		}

Original file line number	Diff line number	Diff line change
`@@ -420,9 +420,10 @@ func updateWebhookVolumeConfig(deployment appsv1.Deployment, esc operatorv1alp`
`420`	`420`	`func updateSecretVolumeConfig(deployment *appsv1.Deployment, volumeName, secretName string) {`
`421`	`421`	`volumeExists := false`
`422`	`422`	`for i := range deployment.Spec.Template.Spec.Volumes {`
`423`		`- if deployment.Spec.Template.Spec.Volumes[i].Name == volumeName {`
`424`		`- volumeExists = true`
	`423`	`+ if deployment.Spec.Template.Spec.Volumes[i].Name != volumeName {`
	`424`	`+ continue`
`425`	`425`	`}`
	`426`	`+ volumeExists = true`
`426`	`427`	`if deployment.Spec.Template.Spec.Volumes[i].Secret == nil {`
`427`	`428`	`deployment.Spec.Template.Spec.Volumes[i].Secret = &corev1.SecretVolumeSource{}`
`428`	`429`	`}`