Skip to content

Commit 174dce1

Browse files
Merge pull request #9950 from barbacbd/OCPBUGS-61901
OCPBUGS-61901: Update explain for Publish
2 parents ba8a348 + 8393261 commit 174dce1

File tree

4 files changed

+9
-3
lines changed

4 files changed

+9
-3
lines changed

data/data/install.openshift.io_installconfigs.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7837,11 +7837,13 @@ spec:
78377837
default: External
78387838
description: |-
78397839
Publish controls how the user facing endpoints of the cluster like the Kubernetes API, OpenShift routes etc. are exposed.
7840+
A "Mixed" strategy only applies to the "azure" platform, and requires "operatorPublishingStrategy" to be configured.
78407841
When no strategy is specified, the strategy is "External".
78417842
enum:
78427843
- ""
78437844
- External
78447845
- Internal
7846+
- Mixed
78457847
type: string
78467848
pullSecret:
78477849
description: PullSecret is the secret to use when pulling images.

pkg/explain/fields_lookup_test.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ func Test_lookup(t *testing.T) {
2020
}, {
2121
path: []string{"publish"},
2222
desc: `Publish controls how the user facing endpoints of the cluster like the Kubernetes API, OpenShift routes etc. are exposed.
23+
A "Mixed" strategy only applies to the "azure" platform, and requires "operatorPublishingStrategy" to be configured.
2324
When no strategy is specified, the strategy is "External".`,
2425
}, {
2526
path: []string{"publish", "unknown"},

pkg/explain/printer_test.go

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -143,8 +143,9 @@ If unset, the cluster will not be configured to use a proxy.
143143
144144
publish <string>
145145
Default: "External"
146-
Valid Values: "","External","Internal"
146+
Valid Values: "","External","Internal","Mixed"
147147
Publish controls how the user facing endpoints of the cluster like the Kubernetes API, OpenShift routes etc. are exposed.
148+
A "Mixed" strategy only applies to the "azure" platform, and requires "operatorPublishingStrategy" to be configured.
148149
When no strategy is specified, the strategy is "External".
149150
150151
pullSecret <string> -required-
@@ -414,8 +415,9 @@ VERSION: v1
414415
415416
RESOURCE: <string>
416417
Default: "External"
417-
Valid Values: "","External","Internal"
418+
Valid Values: "","External","Internal","Mixed"
418419
Publish controls how the user facing endpoints of the cluster like the Kubernetes API, OpenShift routes etc. are exposed.
420+
A "Mixed" strategy only applies to the "azure" platform, and requires "operatorPublishingStrategy" to be configured.
419421
When no strategy is specified, the strategy is "External".
420422
`,
421423
}, {

pkg/types/installconfig.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ var (
6363
)
6464

6565
// PublishingStrategy is a strategy for how various endpoints for the cluster are exposed.
66-
// +kubebuilder:validation:Enum="";External;Internal
66+
// +kubebuilder:validation:Enum="";External;Internal;Mixed
6767
type PublishingStrategy string
6868

6969
const (
@@ -157,6 +157,7 @@ type InstallConfig struct {
157157
ImageDigestSources []ImageDigestSource `json:"imageDigestSources,omitempty"`
158158

159159
// Publish controls how the user facing endpoints of the cluster like the Kubernetes API, OpenShift routes etc. are exposed.
160+
// A "Mixed" strategy only applies to the "azure" platform, and requires "operatorPublishingStrategy" to be configured.
160161
// When no strategy is specified, the strategy is "External".
161162
//
162163
// +kubebuilder:default=External

0 commit comments

Comments
 (0)