Skip to content

Commit 412a878

Browse files
Merge pull request #8386 from bfournie/capg-k8s-fw-tag
OCPBUGS-33481: set the node tag used by CAPG for CloudProviderConfig
2 parents 7f7c54c + ccdea83 commit 412a878

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

pkg/asset/manifests/gcp/cloudproviderconfig.go

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,8 +36,9 @@ func CloudProviderConfig(infraID, projectID, subnet, networkProjectID string) (s
3636
Regional: true,
3737
Multizone: true,
3838

39-
// To make sure k8s cloud provide has tags for firewal for load balancer.
40-
NodeTags: []string{fmt.Sprintf("%s-master", infraID), fmt.Sprintf("%s-worker", infraID)},
39+
// To make sure k8s cloud provider has tags for firewall for load balancer.
40+
// The CAPI gcp provider uses the node tag "control-plane" for master nodes.
41+
NodeTags: []string{fmt.Sprintf("%s-master", infraID), fmt.Sprintf("%s-control-plane", infraID), fmt.Sprintf("%s-worker", infraID)},
4142
NodeInstancePrefix: infraID,
4243
ExternalInstanceGroupsPrefix: infraID,
4344

pkg/asset/manifests/gcp/cloudproviderconfig_test.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ project-id = test-project-id
1212
regional = true
1313
multizone = true
1414
node-tags = uid-master
15+
node-tags = uid-control-plane
1516
node-tags = uid-worker
1617
node-instance-prefix = uid
1718
external-instance-groups-prefix = uid
@@ -30,6 +31,7 @@ project-id = test-project-id
3031
regional = true
3132
multizone = true
3233
node-tags = uid-master
34+
node-tags = uid-control-plane
3335
node-tags = uid-worker
3436
node-instance-prefix = uid
3537
external-instance-groups-prefix = uid

0 commit comments

Comments
 (0)