capi/aws: move ignition s3 bucket name to a function

This way we make sure that all places that rely on the name are in sync.

Author: r4f4

pkg/asset/manifests/aws/cluster.go

@@ -151,7 +151,7 @@ func GenerateClusterAssets(ic *installconfig.InstallConfig, clusterID *installco
 				},
 			},
 			S3Bucket: &capa.S3Bucket{
-				Name:                    fmt.Sprintf("openshift-bootstrap-data-%s", clusterID.InfraID),
+				Name:                    GetIgnitionBucketName(clusterID.InfraID),
 				PresignedURLDuration:    &metav1.Duration{Duration: 1 * time.Hour},
 				BestEffortDeleteObjects: ptr.To(ic.Config.AWS.BestEffortDeleteIgnition),
 			},
@@ -265,3 +265,8 @@ func GenerateClusterAssets(ic *installconfig.InstallConfig, clusterID *installco
 		},
 	}, nil
 }
+
+// GetIgnitionBucketName returns the name of the bucket for the given cluster.
+func GetIgnitionBucketName(infraID string) string {
+	return fmt.Sprintf("openshift-bootstrap-data-%s", infraID)
+}

pkg/infrastructure/aws/clusterapi/aws.go

@@ -322,7 +322,7 @@ func (p *Provider) PostDestroy(ctx context.Context, in clusterapi.PostDestroyerI
 		return fmt.Errorf("failed to create aws session: %w", err)
 	}
 
-	bucketName := fmt.Sprintf("openshift-bootstrap-data-%s", in.Metadata.InfraID)
+	bucketName := awsmanifest.GetIgnitionBucketName(in.Metadata.InfraID)
 	if err := removeS3Bucket(ctx, session, bucketName); err != nil {
 		if p.bestEffortDeleteIgnition {
 			logrus.Warnf("failed to delete ignition bucket %s: %v", bucketName, err)