CORS-3419: Include baremetal IPI in openshift-installer

Now that we do not dynamically link to libvirt, there is no need to
restrict baremetal IPI to the openshift-baremetal-installer binary and
it can be included in all builds of the installer.

Author: zaneb

pkg/destroy/baremetal/baremetal.go

@@ -1,6 +1,3 @@
-//go:build baremetal
-// +build baremetal
-
 package baremetal
 
 import (

pkg/destroy/baremetal/register.go

@@ -1,6 +1,3 @@
-//go:build baremetal
-// +build baremetal
-
 // Package baremetal provides a cluster-destroyer for bare metal clusters.
 package baremetal
 

pkg/types/baremetal/validation/libvirt.go

@@ -1,6 +1,3 @@
-//go:build baremetal
-// +build baremetal
-
 package validation
 
 import (
@@ -12,10 +9,6 @@ import (
 	"github.com/sirupsen/logrus"
 )
 
-func init() {
-	interfaceValidator = libvirtInterfaceValidator
-}
-
 // libvirtInterfaceValidator fetches the valid interface names from a particular libvirt instance, and returns a closure
 // to validate if an interface is found among them
 func libvirtInterfaceValidator(libvirtURI string) (func(string) error, error) {

pkg/types/baremetal/validation/platform.go

@@ -28,7 +28,7 @@ import (
 
 type interfaceValidatorFactory func(string) (func(string) error, error)
 
-var interfaceValidator interfaceValidatorFactory
+var interfaceValidator interfaceValidatorFactory = libvirtInterfaceValidator
 
 func validateIPinMachineCIDR(vip string, n *types.Networking) error {
 	var networks []string

pkg/types/installconfig.go

@@ -38,6 +38,7 @@ var (
 	PlatformNames = []string{
 		aws.Name,
 		azure.Name,
+		baremetal.Name,
 		gcp.Name,
 		ibmcloud.Name,
 		nutanix.Name,
@@ -49,7 +50,6 @@ var (
 	// hidden-but-supported platform names. This list isn't presented
 	// to the user in the interactive wizard.
 	HiddenPlatformNames = []string{
-		baremetal.Name,
 		external.Name,
 		none.Name,
 	}