baremetal: remove stages

Author: honza

data/data/baremetal/OWNERS

@@ -9,40 +9,44 @@ import (
 	"github.com/openshift/installer/pkg/types"
 )
 
+// Provider is the baremetal platform provider.
 type Provider struct{}
 
+// InitializeProvider initializes an empty Provider.
 func InitializeProvider() infrastructure.Provider {
 	return Provider{}
 }
 
 // Provision creates a baremetal platform bootstrap node.
 func (a Provider) Provision(ctx context.Context, dir string, parents asset.Parents) ([]*asset.File, error) {
-	config, err := GetConfig(dir)
+	config, err := getConfig(dir)
 	if err != nil {
-		return []*asset.File{}, fmt.Errorf("failed to get baremetal platform config: %v", err)
+		return []*asset.File{}, fmt.Errorf("failed to get baremetal platform config: %w", err)
 	}
 
 	err = createBootstrap(config)
 	if err != nil {
-		return []*asset.File{}, fmt.Errorf("failed to create bootstrap: %v", err)
+		return []*asset.File{}, fmt.Errorf("failed to create bootstrap: %w", err)
 	}
 
 	return []*asset.File{}, nil
 }
 
+// DestroyBootstrap destroys the temporary bootstrap resources.
 func (a Provider) DestroyBootstrap(dir string) error {
-	config, err := GetConfig(dir)
+	config, err := getConfig(dir)
 	if err != nil {
-		return fmt.Errorf("failed to get baremetal platform config: %v", err)
+		return fmt.Errorf("failed to get baremetal platform config: %w", err)
 	}
 	err = destroyBootstrap(config)
 	if err != nil {
-		return fmt.Errorf("failed to create bootstrap: %v", err)
+		return fmt.Errorf("failed to create bootstrap: %w", err)
 	}
 
 	return nil
 }
 
+// ExtractHostAddresses extracts the IPs of the bootstrap and control plane machines.
 func (a Provider) ExtractHostAddresses(dir string, ic *types.InstallConfig, ha *infrastructure.HostAddresses) error {
 	ha.Bootstrap = ic.Platform.BareMetal.BootstrapProvisioningIP
 

data/data/baremetal/bootstrap/README.md

@@ -9,7 +9,6 @@ import (
 
 	"github.com/digitalocean/go-libvirt"
 	"github.com/sirupsen/logrus"
-
 	"libvirt.org/go/libvirtxml"
 )
 

data/data/baremetal/bootstrap/main.tf

@@ -18,12 +18,12 @@ type defIgnition struct {
 func (ign *defIgnition) createFile() (string, error) {
 	tempFile, err := os.CreateTemp("", ign.Name)
 	if err != nil {
-		return "", fmt.Errorf("Error creating tmp file: %v", err)
+		return "", fmt.Errorf("error creating tmp file: %w", err)
 	}
 	defer tempFile.Close()
 
 	if _, err := tempFile.WriteString(ign.Content); err != nil {
-		return "", fmt.Errorf("Cannot write Ignition object to temporary " +
+		return "", fmt.Errorf("cannot write Ignition object to temporary " +
 			"ignition file")
 	}
 
@@ -38,7 +38,7 @@ func (ign *defIgnition) CreateAndUpload(client *libvirt.Libvirt) (string, error)
 
 	err = client.StoragePoolRefresh(pool, 0)
 	if err != nil {
-		return "", fmt.Errorf("failed to refresh pool %v", err)
+		return "", fmt.Errorf("failed to refresh pool %w", err)
 	}
 
 	volumeDef := newVolume(ign.Name)
@@ -49,7 +49,7 @@ func (ign *defIgnition) CreateAndUpload(client *libvirt.Libvirt) (string, error)
 	}
 	defer func() {
 		if err = os.Remove(ignFile); err != nil {
-			logrus.Errorf("Error while removing tmp Ignition file: %v", err)
+			logrus.Errorf("error while removing tmp Ignition file: %s", err)
 		}
 	}()
 
@@ -69,17 +69,17 @@ func (ign *defIgnition) CreateAndUpload(client *libvirt.Libvirt) (string, error)
 
 	volumeDefXML, err := xml.Marshal(volumeDef)
 	if err != nil {
-		return "", fmt.Errorf("Error serializing libvirt volume: %s", err)
+		return "", fmt.Errorf("error serializing libvirt volume: %w", err)
 	}
 
 	volume, err := client.StorageVolCreateXML(pool, string(volumeDefXML), 0)
 	if err != nil {
-		return "", fmt.Errorf("Error creating libvirt volume for Ignition %s: %s", ign.Name, err)
+		return "", fmt.Errorf("error creating libvirt volume for Ignition %s: %w", ign.Name, err)
 	}
 
 	err = img.Import(newCopier(client, volume, volumeDef.Capacity.Value), volumeDef)
 	if err != nil {
-		return "", fmt.Errorf("Error while uploading ignition file %s: %s", img.String(), err)
+		return "", fmt.Errorf("error while uploading ignition file %s: %w", img.String(), err)
 	}
 
 	return "", nil