Skip to content

Commit a132f85

Browse files
committed
pkg/asset: update tests to accept context
Updates tests to accept a context after the interface for the asset store was updated.
1 parent 2fcba69 commit a132f85

File tree

2 files changed

+7
-5
lines changed

2 files changed

+7
-5
lines changed

pkg/asset/store/assetcreate_test.go

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
package store
22

33
import (
4+
"context"
45
"os"
56
"path/filepath"
67
"reflect"
@@ -100,7 +101,7 @@ func TestCreatedAssetsAreNotDirty(t *testing.T) {
100101
}
101102

102103
for _, a := range tc.targets {
103-
if err := assetStore.Fetch(a, tc.targets...); err != nil {
104+
if err := assetStore.Fetch(context.TODO(), a, tc.targets...); err != nil {
104105
t.Fatalf("failed to fetch %q: %v", a.Name(), err)
105106
}
106107

@@ -125,7 +126,7 @@ func TestCreatedAssetsAreNotDirty(t *testing.T) {
125126
for _, a := range tc.targets {
126127
name := a.Name()
127128
newAsset := reflect.New(reflect.TypeOf(a).Elem()).Interface().(asset.WritableAsset)
128-
if err := newAssetStore.Fetch(newAsset, tc.targets...); err != nil {
129+
if err := newAssetStore.Fetch(context.TODO(), newAsset, tc.targets...); err != nil {
129130
t.Fatalf("failed to fetch %q in new store: %v", a.Name(), err)
130131
}
131132
assetState := newAssetStore.assets[reflect.TypeOf(a)]

pkg/asset/store/store_test.go

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
package store
22

33
import (
4+
"context"
45
"os"
56
"path/filepath"
67
"reflect"
@@ -281,7 +282,7 @@ func TestStoreFetch(t *testing.T) {
281282
source: generatedSource,
282283
}
283284
}
284-
err := store.Fetch(assets[tc.target])
285+
err := store.Fetch(context.TODO(), assets[tc.target])
285286
assert.NoError(t, err, "error fetching asset")
286287
assert.EqualValues(t, tc.expectedGenerationLog, generationLog)
287288
})
@@ -375,7 +376,7 @@ func TestStoreFetchOnDiskAssets(t *testing.T) {
375376
for _, name := range tc.onDiskAssets {
376377
onDiskAssets[reflect.TypeOf(assets[name])] = true
377378
}
378-
err := store.fetch(assets[tc.target], "")
379+
err := store.fetch(context.TODO(), assets[tc.target], "")
379380
assert.NoError(t, err, "unexpected error")
380381
assert.EqualValues(t, tc.expectedGenerationLog, generationLog)
381382
assert.Equal(t, tc.expectedDirty, store.assets[reflect.TypeOf(assets[tc.target])].anyParentsDirty)
@@ -395,7 +396,7 @@ func TestStoreFetchIdempotency(t *testing.T) {
395396
}
396397
assets := []asset.WritableAsset{&testStoreAssetA{}, &testStoreAssetB{}}
397398
for _, a := range assets {
398-
err = store.Fetch(a, assets...)
399+
err = store.Fetch(context.TODO(), a, assets...)
399400
if !assert.NoError(t, err, "(loop %d) unexpected error fetching asset %q", a.Name()) {
400401
t.Fatal()
401402
}

0 commit comments

Comments
 (0)