Skip to content

Commit cda36fc

Browse files
Merge pull request #8538 from r4f4/aws-master-user-data
OCPBUGS-35020: capi/aws: don't use S3 stub for masters
2 parents 17c0f49 + 408eb9c commit cda36fc

File tree

2 files changed

+13
-3
lines changed

2 files changed

+13
-3
lines changed

pkg/asset/machines/aws/awsmachines.go

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -112,6 +112,10 @@ func GenerateMachines(clusterID string, in *MachineInput) ([]*asset.RuntimeFile,
112112
if in.Role == "bootstrap" {
113113
awsMachine.Name = capiutils.GenerateBoostrapMachineName(clusterID)
114114
awsMachine.Labels["install.openshift.io/bootstrap"] = ""
115+
awsMachine.Spec.Ignition.StorageType = capa.IgnitionStorageTypeOptionClusterObjectStore
116+
} else {
117+
// master machines should get ignition from the MCS on the bootstrap node
118+
awsMachine.Spec.Ignition.StorageType = capa.IgnitionStorageTypeOptionUnencryptedUserData
115119
}
116120

117121
// Handle additional security groups.

pkg/asset/machines/aws/awsmachines_test.go

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,9 @@ var stubMachineInputManagedVpc = &MachineInput{
3030
Subnets: make(map[string]string, 0),
3131
Tags: capa.Tags{},
3232
PublicIP: false,
33-
Ignition: &capa.Ignition{},
33+
Ignition: &capa.Ignition{
34+
StorageType: capa.IgnitionStorageTypeOptionUnencryptedUserData,
35+
},
3436
}
3537

3638
func stubDeepCopyMachineInput(in *MachineInput) *MachineInput {
@@ -115,7 +117,9 @@ func TestGenerateMachines(t *testing.T) {
115117
Encrypted: ptr.To(true),
116118
},
117119
UncompressedUserData: ptr.To(true),
118-
Ignition: &capa.Ignition{},
120+
Ignition: &capa.Ignition{
121+
StorageType: capa.IgnitionStorageTypeOptionUnencryptedUserData,
122+
},
119123
},
120124
}
121125
infraMachineFiles = append(infraMachineFiles, &asset.RuntimeFile{
@@ -169,7 +173,9 @@ func TestGenerateMachines(t *testing.T) {
169173
Encrypted: ptr.To(true),
170174
},
171175
UncompressedUserData: ptr.To(true),
172-
Ignition: &capa.Ignition{},
176+
Ignition: &capa.Ignition{
177+
StorageType: capa.IgnitionStorageTypeOptionUnencryptedUserData,
178+
},
173179
},
174180
}
175181
infraMachineFiles = append(infraMachineFiles, &asset.RuntimeFile{

0 commit comments

Comments
 (0)