Skip to content

Commit ceb5988

Browse files
committed
azure: Allow for installation in existing resource group
Use the existing resource group if the user sets the value for CAPI installation.
1 parent 911203d commit ceb5988

File tree

4 files changed

+5
-5
lines changed

4 files changed

+5
-5
lines changed

pkg/asset/machines/clusterapi.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -247,7 +247,7 @@ func (c *ClusterAPI) Generate(dependencies asset.Parents) error {
247247
// useImageGallery := installConfig.Azure.CloudName != azuretypes.StackCloud
248248
useImageGallery := false
249249
masterUserDataSecretName := "master-user-data"
250-
resourceGroupName := fmt.Sprintf("%s-rg", clusterID.InfraID)
250+
resourceGroupName := installConfig.Config.Azure.ClusterResourceGroupName(clusterID.InfraID)
251251

252252
azureMachines, err := azure.GenerateMachines(installConfig.Config.Platform.Azure, &pool, masterUserDataSecretName, clusterID.InfraID, "master", capabilities, useImageGallery, installConfig.Config.Platform.Azure.UserTags, hyperVGen, subnet, resourceGroupName, session.Credentials.SubscriptionID)
253253
if err != nil {

pkg/asset/manifests/azure/cluster.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,13 +37,14 @@ func GenerateClusterAssets(installConfig *installconfig.InstallConfig, clusterID
3737
File: asset.File{Filename: "00_azure-namespace.yaml"},
3838
})
3939

40+
resourceGroup := installConfig.Config.Platform.Azure.ClusterResourceGroupName(clusterID.InfraID)
4041
azureCluster := &capz.AzureCluster{
4142
ObjectMeta: metav1.ObjectMeta{
4243
Name: clusterID.InfraID,
4344
Namespace: capiutils.Namespace,
4445
},
4546
Spec: capz.AzureClusterSpec{
46-
ResourceGroup: fmt.Sprintf("%s-rg", clusterID.InfraID),
47+
ResourceGroup: resourceGroup,
4748
AzureClusterClassSpec: capz.AzureClusterClassSpec{
4849
SubscriptionID: session.Credentials.SubscriptionID,
4950
Location: installConfig.Config.Azure.Region,

pkg/infrastructure/azure/azure.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -370,7 +370,7 @@ func (p *Provider) InfraReady(ctx context.Context, in clusterapi.InfraReadyInput
370370
p.StorageAccountKeys = storageAccountKeys
371371
p.lbBackendAddressPool = lbBap
372372

373-
if err := createDNSEntries(ctx, in, extLBFQDN); err != nil {
373+
if err := createDNSEntries(ctx, in, extLBFQDN, resourceGroupName); err != nil {
374374
return fmt.Errorf("error creating DNS records: %w", err)
375375
}
376376

pkg/infrastructure/azure/dns.go

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,14 +37,13 @@ type recordPrivateList struct {
3737
}
3838

3939
// Create DNS entries for azure.
40-
func createDNSEntries(ctx context.Context, in clusterapi.InfraReadyInput, extLBFQDN string) error {
40+
func createDNSEntries(ctx context.Context, in clusterapi.InfraReadyInput, extLBFQDN string, resourceGroup string) error {
4141
private := in.InstallConfig.Config.Publish == types.InternalPublishingStrategy
4242
baseDomainResourceGroup := in.InstallConfig.Config.Azure.BaseDomainResourceGroupName
4343
zone := in.InstallConfig.Config.BaseDomain
4444
privatezone := in.InstallConfig.Config.ClusterDomain()
4545
apiExternalName := fmt.Sprintf("api.%s", in.InstallConfig.Config.ObjectMeta.Name)
4646

47-
resourceGroup := fmt.Sprintf("%s-rg", in.InfraID)
4847
if in.InstallConfig.Config.Azure.ResourceGroupName != "" {
4948
resourceGroup = in.InstallConfig.Config.Azure.ResourceGroupName
5049
}

0 commit comments

Comments
 (0)