Merge pull request #8218 from r4f4/capi-log-to-file

CORS-3436: capi: save log output to file

Author: openshift-merge-bot[bot]

pkg/clusterapi/system.go

@@ -4,6 +4,7 @@ import (
 	"bytes"
 	"context"
 	"fmt"
+	"io"
 	"net/url"
 	"os"
 	"path/filepath"
@@ -72,6 +73,8 @@ type system struct {
 	wg           sync.WaitGroup
 	teardownOnce sync.Once
 	cancel       context.CancelFunc
+
+	logWriter *io.PipeWriter
 }
 
 // Run launches the cluster-api system.
@@ -272,6 +275,9 @@ func (c *system) Run(ctx context.Context, installConfig *installconfig.InstallCo
 		return fmt.Errorf("unsupported platform %q", platform)
 	}
 
+	// We only show controller logs if the log level is DEBUG or above
+	c.logWriter = logrus.StandardLogger().WriterLevel(logrus.DebugLevel)
+
 	// Run the controllers.
 	for _, ct := range controllers {
 		if err := c.runController(ctx, ct); err != nil {
@@ -341,6 +347,8 @@ func (c *system) Teardown() {
 		case <-time.After(60 * time.Second):
 			logrus.Warn("Timed out waiting for local Cluster API system to shut down")
 		}
+
+		c.logWriter.Close()
 	})
 }
 
@@ -505,7 +513,7 @@ func (c *system) runController(ctx context.Context, ct *controller) error {
 
 	// Run the controller and store its state.
 	logrus.Infof("Running process: %s with args %v", ct.Name, ct.Args)
-	if err := pr.Start(ctx, os.Stdout, os.Stderr); err != nil {
+	if err := pr.Start(ctx, c.logWriter, c.logWriter); err != nil {
 		return fmt.Errorf("failed to start controller %q: %w", ct.Name, err)
 	}
 	ct.state = pr