pkg/gather: analyze konnectivity failures

Adds error handling to report konnectivity specific failures
when running gather bootstrap or analyze.

Author: patrickdillon

pkg/gather/service/analyze.go

@@ -114,18 +114,20 @@ func checkReleaseImageDownload(a analysis) bool {
 	return false
 }
 
-// bootstrap-verify-api-servel-urls.sh is currently running as part of the bootkube service.
-// And the verification of the API and API-Int URLs are the only stage where a failure is
-// currently reported. So, here we are able to conclude that a failure corresponds to a
-// failure to resolve either the API URL or API-Int URL or both. If that changes and if
-// any other stage in the bootkube service starts reporting a failure, we need to revisit
-// this. At that point verification of the URLs could be moved to its own service.
 func checkBootkubeService(a analysis) bool {
 	if a.successful {
 		return true
 	}
-	// Note: Even when there is a stage failure, we are not returning false here. That is
-	// intentional because we donot want to report this as an error in the "analyze" output.
+	switch a.failingStage {
+	case "konnectivity-certs":
+		logrus.Error("The bootstrap machine failed to generate konnectivity certificates")
+	case "konnectivity-server-bootstrap":
+		logrus.Error("The bootstrap machine failed to start the konnectivity server")
+	case "konnectivity-agent-manifest":
+		logrus.Error("The bootstrap machine failed to create konnectivity agent manifests")
+	case "konnectivity-cleanup":
+		logrus.Error("The bootstrap machine failed to clean up konnectivity resources")
+	}
 	a.logLastError()
 	return true
 }