Skip to content

Commit ea2f3a1

Browse files
committed
baremetal bootstrap: Downgrade Requires dependencies to Wants
Since the image customization service now runs as a kubernetes controller, it is no longer directly required by ironic (as it was when it ran on static data and Terraform was doing the provisioning). Ironic needs only the kernel to be set up by extract-machine-os, which was previously a transitive dependency. And although it is wanted by BMO, it should not block BMO startup as BMO may be able to at least provide some useful debugging information in the CRDs if the image-customization service is not running. In turn, the image-customization controller can run and potentially provide useful error messages if the CoreOS ISO file does not exist, so use Wants instead of Requires to depend on extract-machine-os.
1 parent e4a744c commit ea2f3a1

File tree

3 files changed

+8
-8
lines changed

3 files changed

+8
-8
lines changed

data/data/bootstrap/baremetal/files/etc/containers/systemd/image-customization.container

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
[Unit]
22
Description=Customized Machine OS Image Server
33
BindsTo=ironic-volume.service
4-
Requires=build-ironic-env.service extract-machine-os.service
4+
Requires=build-ironic-env.service
55
PartOf=ironic.service
6-
Wants=network-online.target
6+
Wants=network-online.target extract-machine-os.service
77
After=network-online.target ironic-volume.service build-ironic-env.service extract-machine-os.service
88

99
[Container]

data/data/bootstrap/baremetal/files/etc/containers/systemd/ironic.container.template

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,15 @@
11
[Unit]
22
Description=Ironic baremetal deployment service
33
BindsTo=ironic-volume.service
4-
Requires=build-ironic-env.service wait-iptables-init.service image-customization.service
4+
Requires=build-ironic-env.service wait-iptables-init.service
55
{{ if .PlatformData.BareMetal.ProvisioningIP }}
66
Requires=provisioning-interface.service
77
{{ end }}
88
{{ if .PlatformData.BareMetal.ProvisioningDNSMasq }}
99
Wants=ironic-dnsmasq.service
1010
{{ end }}
11-
Wants=network-online.target ironic-httpd.service ironic-ramdisk-logs.service
12-
After=network-online.target ironic-volume.service build-ironic-env.service wait-iptables-init.service provisioning-interface.service ironic-dnsmasq.service image-customization.service
11+
Wants=network-online.target ironic-httpd.service ironic-ramdisk-logs.service extract-machine-os.service
12+
After=network-online.target ironic-volume.service build-ironic-env.service wait-iptables-init.service provisioning-interface.service ironic-dnsmasq.service extract-machine-os.service
1313

1414
[Container]
1515
ContainerName=ironic

data/data/bootstrap/baremetal/files/etc/containers/systemd/metal3-baremetal-operator.container

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
[Unit]
22
Description=Metal3 deployment service
3-
Requires=build-metal3-env.service image-customization.service ironic.service
4-
Wants=network-online.target
5-
After=network-online.target image-customization.service build-metal3-env.service
3+
Requires=build-metal3-env.service ironic.service
4+
Wants=network-online.target image-customization.service
5+
After=network-online.target build-metal3-env.service
66

77
[Container]
88
ContainerName=baremetal-operator

0 commit comments

Comments
 (0)