Skip to content

Commit fbfdc12

Browse files
Merge pull request #8258 from barbacbd/OCPBUGS-31711
OCPBUGS-31711: AWS update explain docs
2 parents 3a6a99a + c6f91d6 commit fbfdc12

File tree

3 files changed

+11
-11
lines changed

3 files changed

+11
-11
lines changed

data/data/install.openshift.io_installconfigs.yaml

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2271,12 +2271,13 @@ spec:
22712271
type: string
22722272
lbType:
22732273
description: "LBType is an optional field to specify a load balancer
2274-
type. \n When this field is specified, the default ingresscontroller
2275-
will be created using the specified load-balancer type. \n Following
2276-
are the accepted values: \n * \"Classic\": A Classic Load Balancer
2277-
that makes routing decisions at either the transport layer (TCP/SSL)
2278-
or the application layer (HTTP/HTTPS). See the following for
2279-
additional details: https://docs.aws.amazon.com/AmazonECS/latest/developerguide/load-balancer-types.html#clb
2274+
type. When this field is specified, all ingresscontrollers (including
2275+
the default ingresscontroller) will be created using the specified
2276+
load-balancer type by default. \n Following are the accepted
2277+
values: \n * \"Classic\": A Classic Load Balancer that makes
2278+
routing decisions at either the transport layer (TCP/SSL) or
2279+
the application layer (HTTP/HTTPS). See the following for additional
2280+
details: https://docs.aws.amazon.com/AmazonECS/latest/developerguide/load-balancer-types.html#clb
22802281
\n * \"NLB\": A Network Load Balancer that makes routing decisions
22812282
at the transport layer (TCP/SSL). See the following for additional
22822283
details: https://docs.aws.amazon.com/AmazonECS/latest/developerguide/load-balancer-types.html#nlb

pkg/explain/printer_test.go

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -166,8 +166,7 @@ func Test_PrintFields(t *testing.T) {
166166
HostedZoneRole is the ARN of an IAM role to be assumed when performing operations on the provided HostedZone. HostedZoneRole can be used in a shared VPC scenario when the private hosted zone belongs to a different account than the rest of the cluster resources. If HostedZoneRole is set, HostedZone must also be set.
167167
168168
lbType <string>
169-
LBType is an optional field to specify a load balancer type.
170-
When this field is specified, the default ingresscontroller will be created using the specified load-balancer type.
169+
LBType is an optional field to specify a load balancer type. When this field is specified, all ingresscontrollers (including the default ingresscontroller) will be created using the specified load-balancer type by default.
171170
Following are the accepted values:
172171
* "Classic": A Classic Load Balancer that makes routing decisions at either the transport layer (TCP/SSL) or the application layer (HTTP/HTTPS). See the following for additional details: https://docs.aws.amazon.com/AmazonECS/latest/developerguide/load-balancer-types.html#clb
173172
* "NLB": A Network Load Balancer that makes routing decisions at the transport layer (TCP/SSL). See the following for additional details: https://docs.aws.amazon.com/AmazonECS/latest/developerguide/load-balancer-types.html#nlb

pkg/types/aws/platform.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -81,9 +81,9 @@ type Platform struct {
8181
PropagateUserTag bool `json:"propagateUserTags,omitempty"`
8282

8383
// LBType is an optional field to specify a load balancer type.
84-
//
85-
// When this field is specified, the default ingresscontroller will be
86-
// created using the specified load-balancer type.
84+
// When this field is specified, all ingresscontrollers (including the
85+
// default ingresscontroller) will be created using the specified load-balancer
86+
// type by default.
8787
//
8888
// Following are the accepted values:
8989
//

0 commit comments

Comments
 (0)