OCPBUGS-63305: Make SimulatePrincipalPolicy optional

[barbacbd]

Removing SimulatePrincipalPolicy as a required permission for Mint and Passthrough modes. Instead it will be required when a credential mode is not set.

[openshift-ci-robot]

@barbacbd: This pull request references Jira Issue OCPBUGS-63305, which is invalid:

• expected the bug to target the "4.21.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Removing SimulatePrincipalPolicy as a required permission for Mint and Passthrough modes. Instead it will be required when a credential mode is not set.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[barbacbd]

/cc @tthvo
/cc @patrickdillon

[barbacbd]

/jira refresh

[openshift-ci-robot]

@barbacbd: This pull request references Jira Issue OCPBUGS-63305, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.21.0) matches configured target version for branch (4.21.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @gpei

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign tthvo for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[tthvo]

Suggested change

	case "":
	reqGroups = append(reqGroups, awsconfig.PermissionEmptyCreds)
	default:
	// Include permissions needed by CCO/cluster for mint creds mode
	reqGroups = append(reqGroups, awsconfig.PermissionMintCreds)
	default:
	// Include permissions needed by installer and CCO to perform permission checks.
	if ic.Config.CredentialsMode == "" {
	reqGroups = append(reqGroups, awsconfig.PermissionEmptyCreds)
	}
	// Include permissions needed by CCO/cluster for mint creds mode
	reqGroups = append(reqGroups, awsconfig.PermissionMintCreds)

The empty credentialsMode is basically Mint + SimulatePrincipalPolicy for permission check right?

[tthvo]

Otherwise, if when the default credential mode is used, the installer says that only SimulatePrincipalPolicy is required, which is not right?

[openshift-ci]

@barbacbd: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-ovn-single-node	12cd06c	link	false	/test e2e-aws-ovn-single-node
ci/prow/e2e-aws-ovn	12cd06c	link	true	/test e2e-aws-ovn
ci/prow/e2e-aws-ovn-heterogeneous	12cd06c	link	false	/test e2e-aws-ovn-heterogeneous
ci/prow/e2e-aws-ovn-imdsv2	12cd06c	link	false	/test e2e-aws-ovn-imdsv2
ci/prow/okd-scos-e2e-aws-ovn	12cd06c	link	false	/test okd-scos-e2e-aws-ovn
ci/prow/e2e-aws-byo-subnet-role-security-groups	12cd06c	link	false	/test e2e-aws-byo-subnet-role-security-groups
ci/prow/e2e-aws-ovn-shared-vpc-custom-security-groups	12cd06c	link	false	/test e2e-aws-ovn-shared-vpc-custom-security-groups
ci/prow/e2e-aws-ovn-shared-vpc-edge-zones	12cd06c	link	false	/test e2e-aws-ovn-shared-vpc-edge-zones
ci/prow/e2e-aws-ovn-edge-zones	12cd06c	link	false	/test e2e-aws-ovn-edge-zones
ci/prow/e2e-aws-default-config	12cd06c	link	false	/test e2e-aws-default-config

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[tthvo]

Looks like have a tiny problem 🤔 related to #10081 (comment). Jobs are failing with:

level=warning msg=Action not allowed with tested creds action=iam:CreateAccessKey
level=warning msg=Action not allowed with tested creds action=iam:CreateUser
level=warning msg=Action not allowed with tested creds action=iam:DeleteUserPolicy
level=warning msg=Action not allowed with tested creds action=iam:GetUserPolicy
level=warning msg=Action not allowed with tested creds action=iam:ListAccessKeys
level=warning msg=Action not allowed with tested creds action=iam:PutUserPolicy
level=warning msg=Action not allowed with tested creds action=iam:TagUser
level=warning msg=Tested creds not able to perform all requested actions
level=warning msg=Action not allowed with tested creds action=s3:PutLifecycleConfiguration
level=warning msg=Action not allowed with tested creds action=s3:ListBucketMultipartUploads
level=warning msg=Action not allowed with tested creds action=s3:AbortMultipartUpload
level=warning msg=Action not allowed with tested creds action=iam:GetUserPolicy
level=warning msg=Action not allowed with tested creds action=iam:ListAccessKeys
level=warning msg=Tested creds not able to perform all requested actions
level=fatal msg=failed to fetch Cluster: failed to fetch dependency of "Cluster": failed to generate asset
"Platform Permissions Check": validate AWS credentials: AWS credentials cannot be used to either create
new creds or use as-is
Installer exit with code 1