-
Notifications
You must be signed in to change notification settings - Fork 16
DNM: try gitsubmodules with renovate #516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rphillips The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
4cd9f43
to
09ce150
Compare
/hold I'd really like to see a full e2e on this before we merge. It is not clear to me how the konflux objects would work with this and all the Konflux related work we would need to do to get this work.
|
value: | ||
- linux/x86_64 | ||
- name: dockerfile | ||
value: upstream/release-0.11/Dockerfile |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can't build upstream docker files. We have to use our RHEL ones.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is our dockerfile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, I copied that file into this project.
2d58ceb
to
bf8f1eb
Compare
b285341
to
5d288be
Compare
42b1500
to
fb18371
Compare
fb18371
to
29e38ac
Compare
@rphillips: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
No description provided.