Skip to content

Conversation

rphillips
Copy link
Contributor

No description provided.

@openshift-ci openshift-ci bot requested review from MaysaMacedo and mrunalp August 5, 2025 20:48
Copy link

openshift-ci bot commented Aug 5, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rphillips

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 5, 2025
@rphillips rphillips force-pushed the try_git_submdoules branch from 4cd9f43 to 09ce150 Compare August 5, 2025 21:01
@kannon92
Copy link
Contributor

kannon92 commented Aug 5, 2025

/hold

I'd really like to see a full e2e on this before we merge.

It is not clear to me how the konflux objects would work with this and all the Konflux related work we would need to do to get this work.

  • Konflux builds of operand images
  • Patching the downstream submodules for upstream e2e
  • How will we patch CVE for the operands?
  • Newer versions of Kueue will not be compatable with minimum kubernetes version

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 5, 2025
value:
- linux/x86_64
- name: dockerfile
value: upstream/release-0.11/Dockerfile
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't build upstream docker files. We have to use our RHEL ones.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is our dockerfile

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, I copied that file into this project.

@rphillips rphillips force-pushed the try_git_submdoules branch 2 times, most recently from 2d58ceb to bf8f1eb Compare August 5, 2025 21:09
@rphillips rphillips changed the title try gitsubmodules with renovate DNM: try gitsubmodules with renovate Aug 5, 2025
@rphillips rphillips force-pushed the try_git_submdoules branch from b285341 to 5d288be Compare August 5, 2025 21:50
@rphillips rphillips force-pushed the try_git_submdoules branch 4 times, most recently from 42b1500 to fb18371 Compare August 6, 2025 01:59
@rphillips rphillips force-pushed the try_git_submdoules branch from fb18371 to 29e38ac Compare August 6, 2025 02:02
Copy link

openshift-ci bot commented Aug 6, 2025

@rphillips: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/test-e2e-4-19 29e38ac link true /test test-e2e-4-19
ci/prow/security 29e38ac link false /test security
ci/prow/test-generate 29e38ac link true /test test-generate
ci/prow/test-e2e-4-17 29e38ac link false /test test-e2e-4-17

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@rphillips rphillips closed this Aug 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants