deployment controller should degrade if progressing too long

RomanBednar · RomanBednar · commit b5024a1b240d · 2025-01-13T15:33:34.000+01:00
diff --git a/pkg/operator/deploymentcontroller/deployment_controller.go b/pkg/operator/deploymentcontroller/deployment_controller.go
@@ -300,6 +300,11 @@ func (c *DeploymentController) syncManaged(ctx context.Context, opSpec *opv1.Ope
 				WithMessage(msg).
 				WithReason("Deploying")
 		}
+
+		// Degrade when operator is progressing too long.
+		if v1helpers.IsUpdatingTooLong(opStatus, c.instanceName+opv1.OperatorStatusTypeProgressing) {
+			return fmt.Errorf("Deployment was progressing too long")
+		}
 		status = status.WithConditions(progressingCondition)
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -300,6 +300,11 @@ func (c DeploymentController) syncManaged(ctx context.Context, opSpec opv1.Ope`
`300`	`300`	`WithMessage(msg).`
`301`	`301`	`WithReason("Deploying")`
`302`	`302`	`}`
	`303`	`+`
	`304`	`+ // Degrade when operator is progressing too long.`
	`305`	`+ if v1helpers.IsUpdatingTooLong(opStatus, c.instanceName+opv1.OperatorStatusTypeProgressing) {`
	`306`	`+ return fmt.Errorf("Deployment was progressing too long")`
	`307`	`+ }`
`303`	`308`	`status = status.WithConditions(progressingCondition)`
`304`	`309`	`}`
`305`	`310`