Skip to content

Commit 191a28d

Browse files
Merge pull request #1302 from openshift-cherrypick-robot/cherry-pick-1300-to-release-4.17
[release-4.17] OCPBUGS-43851: vSphere klog initialization preventing verbose log messages
2 parents 139064c + e355c60 commit 191a28d

File tree

1 file changed

+8
-14
lines changed

1 file changed

+8
-14
lines changed

cmd/vsphere/main.go

Lines changed: 8 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@ import (
2424
k8sflag "k8s.io/component-base/cli/flag"
2525
"k8s.io/component-base/featuregate"
2626
"k8s.io/klog/v2"
27-
"k8s.io/klog/v2/textlogger"
2827
ipamv1beta1 "sigs.k8s.io/cluster-api/exp/ipam/api/v1beta1"
2928
ctrl "sigs.k8s.io/controller-runtime"
3029
"sigs.k8s.io/controller-runtime/pkg/cache"
@@ -47,9 +46,14 @@ func main() {
4746
"", "",
4847
)
4948

50-
textLoggerConfig := textlogger.NewConfig()
51-
textLoggerConfig.AddFlags(flag.CommandLine)
52-
ctrl.SetLogger(textlogger.NewLogger(textLoggerConfig))
49+
// Set log for controller-runtime
50+
ctrl.SetLogger(klog.NewKlogr())
51+
52+
klog.InitFlags(nil)
53+
if err := flag.Set("logtostderr", "true"); err != nil {
54+
klog.Fatalf("failed to set logtostderr flag: %v", err)
55+
}
56+
5357
watchNamespace := flag.String(
5458
"namespace",
5559
"",
@@ -81,12 +85,6 @@ func main() {
8185
"Address for hosting metrics",
8286
)
8387

84-
logToStderr := flag.Bool(
85-
"logtostderr",
86-
true,
87-
"log to standard error instead of files",
88-
)
89-
9088
healthAddr := flag.String(
9189
"health-addr",
9290
":9440",
@@ -106,10 +104,6 @@ func main() {
106104

107105
flag.Parse()
108106

109-
if logToStderr != nil {
110-
klog.LogToStderr(*logToStderr)
111-
}
112-
113107
if printVersion {
114108
fmt.Println(version.String)
115109
os.Exit(0)

0 commit comments

Comments
 (0)