Added vSphere check for max networks

Author: vr4manta

pkg/webhooks/machine_webhook.go

@@ -186,6 +186,8 @@ const (
 	maxVSphereDataDiskNameLength = 80
 	// Max size of any data disk in vSphere is 62 TiB.  We are currently limiting to 16TiB (16384 GiB) as a starting point.
 	maxVSphereDataDiskSize = 16384
+	// Max number of networks allowed per machine
+	maxVSphereNetworkCount = 10
 
 	// Nutanix Defaults
 	// Minimum Nutanix values taken from Nutanix reconciler
@@ -1611,6 +1613,11 @@ func validateVSphereNetwork(network machinev1beta1.NetworkSpec, parentPath *fiel
 		return field.ErrorList{field.Required(parentPath.Child("devices"), "at least 1 network device must be provided")}
 	}
 
+	// We currently only support a max of 10 adapters in vSphere based on vSphere limitations
+	if len(network.Devices) > maxVSphereNetworkCount {
+		return field.ErrorList{field.TooMany(parentPath.Child("devices"), len(network.Devices), maxVSphereNetworkCount)}
+	}
+
 	var errs field.ErrorList
 	for i, spec := range network.Devices {
 		fldPath := parentPath.Child("devices").Index(i)

pkg/webhooks/machine_webhook_test.go

@@ -1890,6 +1890,58 @@ func TestMachineUpdate(t *testing.T) {
 			},
 			expectedError: "providerSpec.network.devices: Required value: at least 1 network device must be provided",
 		},
+		{
+			name:         "with an VSphere ProviderSpec, having more than 10 network devices",
+			platformType: osconfigv1.VSpherePlatformType,
+			clusterID:    vsphereClusterID,
+			baseProviderSpecValue: &kruntime.RawExtension{
+				Object: defaultVSphereProviderSpec.DeepCopy(),
+			},
+			updatedProviderSpecValue: func() *kruntime.RawExtension {
+				object := defaultVSphereProviderSpec.DeepCopy()
+				object.Network = machinev1beta1.NetworkSpec{
+					Devices: []machinev1beta1.NetworkDeviceSpec{
+						{
+							NetworkName: "networkName1",
+						},
+						{
+							NetworkName: "networkName2",
+						},
+						{
+							NetworkName: "networkName3",
+						},
+						{
+							NetworkName: "networkName4",
+						},
+						{
+							NetworkName: "networkName5",
+						},
+						{
+							NetworkName: "networkName6",
+						},
+						{
+							NetworkName: "networkName7",
+						},
+						{
+							NetworkName: "networkName8",
+						},
+						{
+							NetworkName: "networkName9",
+						},
+						{
+							NetworkName: "networkName10",
+						},
+						{
+							NetworkName: "networkName11",
+						},
+					},
+				}
+				return &kruntime.RawExtension{
+					Object: object,
+				}
+			},
+			expectedError: "providerSpec.network.devices: Too many: 11: must have at most 10 items",
+		},
 		{
 			name:         "when adding a lifecycle hook",
 			platformType: osconfigv1.AWSPlatformType,