Skip to content

Commit ac37878

Browse files
Merge pull request #1312 from openshift-cherrypick-robot/cherry-pick-1302-to-release-4.16
[release-4.16] OCPBUGS-45947: vSphere klog initialization preventing verbose log messages
2 parents 573fe56 + 4ecb7f2 commit ac37878

File tree

1 file changed

+8
-14
lines changed

1 file changed

+8
-14
lines changed

cmd/vsphere/main.go

Lines changed: 8 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@ import (
2424
"github.com/openshift/machine-api-operator/pkg/version"
2525
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
2626
"k8s.io/klog/v2"
27-
"k8s.io/klog/v2/textlogger"
2827
ipamv1beta1 "sigs.k8s.io/cluster-api/exp/ipam/api/v1beta1"
2928
ctrl "sigs.k8s.io/controller-runtime"
3029
"sigs.k8s.io/controller-runtime/pkg/cache"
@@ -45,9 +44,14 @@ func main() {
4544
"", "",
4645
)
4746

48-
textLoggerConfig := textlogger.NewConfig()
49-
textLoggerConfig.AddFlags(flag.CommandLine)
50-
ctrl.SetLogger(textlogger.NewLogger(textLoggerConfig))
47+
// Set log for controller-runtime
48+
ctrl.SetLogger(klog.NewKlogr())
49+
50+
klog.InitFlags(nil)
51+
if err := flag.Set("logtostderr", "true"); err != nil {
52+
klog.Fatalf("failed to set logtostderr flag: %v", err)
53+
}
54+
5155
watchNamespace := flag.String(
5256
"namespace",
5357
"",
@@ -79,23 +83,13 @@ func main() {
7983
"Address for hosting metrics",
8084
)
8185

82-
logToStderr := flag.Bool(
83-
"logtostderr",
84-
true,
85-
"log to standard error instead of files",
86-
)
87-
8886
healthAddr := flag.String(
8987
"health-addr",
9088
":9440",
9189
"The address for health checking.",
9290
)
9391
flag.Parse()
9492

95-
if logToStderr != nil {
96-
klog.LogToStderr(*logToStderr)
97-
}
98-
9993
if printVersion {
10094
fmt.Println(version.String)
10195
os.Exit(0)

0 commit comments

Comments
 (0)