CFE:1065 add webhook validation for placementGroupPartition

Signed-off-by: chiragkyal <[email protected]>

Author: chiragkyal

pkg/webhooks/machine_webhook.go

@@ -746,6 +746,17 @@ func validateAWS(m *machinev1beta1.Machine, config *admissionConfig) (bool, []st
 		)
 	}
 
+	if providerSpec.PlacementGroupName == "" && providerSpec.PlacementGroupPartition != 0 {
+		errs = append(
+			errs,
+			field.Invalid(
+				field.NewPath("providerSpec", "placementGroupPartition"),
+				providerSpec.PlacementGroupPartition,
+				"providerSpec.placementGroupPartition is set but providerSpec.placementGroupName is empty",
+			),
+		)
+	}
+
 	duplicatedTags := getDuplicatedTags(providerSpec.Tags)
 	if len(duplicatedTags) > 0 {
 		warnings = append(warnings, fmt.Sprintf("providerSpec.tags: duplicated tag names (%s): only the first value will be used.", strings.Join(duplicatedTags, ",")))

pkg/webhooks/machine_webhook_test.go

@@ -2133,6 +2133,30 @@ func TestValidateAWSProviderSpec(t *testing.T) {
 			expectedOk:    false,
 			expectedError: "providerSpec.tenancy: Invalid value: \"invalid\": Invalid providerSpec.tenancy, the only allowed options are: default, dedicated, host",
 		},
+		{
+			testCase: "fail if placementGroupPartition is set, but placementGroupName is empty",
+			modifySpec: func(p *machinev1beta1.AWSMachineProviderConfig) {
+				p.PlacementGroupName = ""
+				p.PlacementGroupPartition = 2
+			},
+			expectedOk:    false,
+			expectedError: "providerSpec.placementGroupPartition: Invalid value: 2: providerSpec.placementGroupPartition is set but providerSpec.placementGroupName is empty",
+		},
+		{
+			testCase: "allow if only placementGroupName is set",
+			modifySpec: func(p *machinev1beta1.AWSMachineProviderConfig) {
+				p.PlacementGroupName = "placement-group"
+			},
+			expectedOk: true,
+		},
+		{
+			testCase: "allow if both placementGroupName and placementGroupPartition are set",
+			modifySpec: func(p *machinev1beta1.AWSMachineProviderConfig) {
+				p.PlacementGroupName = "placement-group"
+				p.PlacementGroupPartition = 2
+			},
+			expectedOk: true,
+		},
 		{
 			testCase: "with no iam instance profile",
 			modifySpec: func(p *machinev1beta1.AWSMachineProviderConfig) {