Update azure zone to non-pointer

Author: RadekManak

pkg/cloud/azure/actuators/machine/actuator_test.go

@@ -414,23 +414,23 @@ func TestAvailabilityZones(t *testing.T) {
 	fakeScope := newFakeScope(t, actuators.ControlPlane)
 	fakeReconciler := newFakeReconcilerWithScope(t, fakeScope)
 
-	fakeReconciler.scope.MachineConfig.Zone = to.StringPtr("2")
+	fakeReconciler.scope.MachineConfig.Zone = "2"
 	fakeReconciler.virtualMachinesSvc = &FakeVMCheckZonesService{
 		checkZones: []string{"2"},
 	}
 	if err := fakeReconciler.Create(context.Background()); err != nil {
 		t.Errorf("failed to create machine: %+v", err)
 	}
 
-	fakeReconciler.scope.MachineConfig.Zone = nil
+	fakeReconciler.scope.MachineConfig.Zone = ""
 	fakeReconciler.virtualMachinesSvc = &FakeVMCheckZonesService{
 		checkZones: []string{""},
 	}
 	if err := fakeReconciler.Create(context.Background()); err != nil {
 		t.Errorf("failed to create machine: %+v", err)
 	}
 
-	fakeReconciler.scope.MachineConfig.Zone = to.StringPtr("1")
+	fakeReconciler.scope.MachineConfig.Zone = "1"
 	fakeReconciler.virtualMachinesSvc = &FakeVMCheckZonesService{
 		checkZones: []string{"3"},
 	}
@@ -441,15 +441,15 @@ func TestAvailabilityZones(t *testing.T) {
 
 func TestGetZone(t *testing.T) {
 	testCases := []struct {
-		inputZone *string
+		inputZone string
 		expected  string
 	}{
 		{
-			inputZone: nil,
+			inputZone: "",
 			expected:  "",
 		},
 		{
-			inputZone: pointer.StringPtr("3"),
+			inputZone: "3",
 			expected:  "3",
 		},
 	}

pkg/cloud/azure/actuators/machine/reconciler.go

@@ -27,7 +27,6 @@ import (
 
 	"github.com/Azure/azure-sdk-for-go/services/compute/mgmt/2021-11-01/compute"
 	"github.com/Azure/go-autorest/autorest"
-	"github.com/Azure/go-autorest/autorest/to"
 	machinev1 "github.com/openshift/api/machine/v1beta1"
 	machinecontroller "github.com/openshift/machine-api-operator/pkg/controller/machine"
 	"github.com/openshift/machine-api-operator/pkg/metrics"
@@ -547,7 +546,7 @@ func (s *Reconciler) Delete(ctx context.Context) error {
 }
 
 func (s *Reconciler) getZone(ctx context.Context) (string, error) {
-	return to.String(s.scope.MachineConfig.Zone), nil
+	return s.scope.MachineConfig.Zone, nil
 }
 
 func (s *Reconciler) createNetworkInterface(ctx context.Context, nicName string) error {